Permalink
Commits on Apr 27, 2017
  1. Add TODO to ThrowableSubject's .hasCauseThat() method.

    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=154208027
    dimo414 committed with cpovirk Apr 25, 2017
Commits on Apr 25, 2017
  1. Introduce AbstractFailureStrategy and add javadocs to FailureStrategy…

    … that references both AbstractFailureStrategy and the common strategy implementations.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=154124248
    dimo414 committed with cpovirk Apr 25, 2017
  2. Introduce a new overload of FailureStrategy.failComparing() that take…

    …s a cause, in order to properly support associating a cause with a comparison failure.
    
    The existing behavior of ThrowableSubject.causeInsertingStrategy().failComparing() is broken if the delegate strategy doesn't throw an AssertionError.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=154088909
    dimo414 committed with cpovirk Apr 24, 2017
Commits on Apr 19, 2017
  1. Remove unnecessary custom FailureStrategy.

    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=153463924
    dimo414 committed with cpovirk Apr 18, 2017
Commits on Apr 4, 2017
  1. Suppress IdentityBinaryExpression

    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=152008533
    cpovirk committed with ronshapiro Apr 3, 2017
  2. Add a check to ensure even number of args to containsExactly() to Map…

    …Subject
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=151647450
    sumitbhagwani committed with ronshapiro Mar 30, 2017
  3. Update documentation from a8ed5a1

    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=151598653
    dimo414 committed with ronshapiro Mar 29, 2017
  4. Fix ErrorProne warning:

      Found aliased type parameters: T declared in AbstractVerb
    
    Went with "D" for "delegated".
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=151592163
    dimo414 committed with ronshapiro Mar 29, 2017
Commits on Mar 23, 2017
  1. Remove the TODO about b/34104379 and leave a note instead.

    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=150316448
    PeteGillinGoogle committed with cpovirk Mar 16, 2017
Commits on Mar 14, 2017
  1. Add missing space in MessageDifferencer checkArgument error text.

    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=149970625
    rusch committed with cpovirk Mar 13, 2017
  2. Add guidance to OptionalSubject about how to make complex assertions …

    …on the value.
    
    XRef: []
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=149771701
    dimo414 committed with cpovirk Mar 10, 2017
Commits on Mar 6, 2017
  1. Add EqualsIncompatibleType suppression in IntegerSubjectTest, as it's…

    … intentionally checking equality of unrelated types.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=149188135
    nglorioso committed with cpovirk Mar 4, 2017
  2. IterableSubject.containsAny{Of,In}() now adds type information when e…

    …lements have same toString()s and objectToStringWithTypeInfo() adds "(null type)" to null references.
    
    Example:
    assertThat(asList(1L, 2L, 3L)).containsAnyOf(2, 3);
    --> Not true that <[1, 2, 3]> contains any of <[2, 3] (java.lang.Integer)>. However, it does contain <[2, 3] (java.lang.Long)>.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=149089679
    nymanjens committed with cpovirk Mar 3, 2017
  3. IterableSubject.containsAll{Of,In}() now adds type information when e…

    …lements have same toString()s.
    
    Example:
    assertThat(asList(1L, 2L)).containsAllOf(1, 2);
    --> Not true that <[1, 2]> contains all of <[1, 2]>. It is missing <[1, 2] (java.lang.Integer)>. However, it does contain <[1, 2] (java.lang.Long)>.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=149089335
    nymanjens committed with cpovirk Mar 3, 2017
Commits on Mar 3, 2017
  1. Add @SuppressWarnings("TruthSelfEquals") to various tests in Truth wh…

    …ich are legitimately testing that path.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=148880346
    PeteGillinGoogle committed with cpovirk Mar 1, 2017
  2. IterableSubject.contains() now adds type information when elements ha…

    …ve same toString()s.
    
    Example:
    assertThat(asList(1L, 2L)).contains(1);
    --> <[1, 2]> should have contained <1 (java.lang.Integer)> but doesn't. However, it does contain <[1] (java.lang.Long)>
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=148821276
    nymanjens committed with cpovirk Feb 28, 2017
Commits on Mar 1, 2017
  1. IterableSubject.containsExactly[ElementsIn]() now adds type informati…

    …on when elements have same toString()s.
    
    Example:
    assertThat(asList(1L, 2L)).containsExactly(1, 2);
    --> Not true that <[1, 2]> contains exactly <[1, 2]>. It is missing <[1, 2] (java.lang.Integers)> and has unexpected items  <[1, 2] (java.lang.Longs)>
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=148645402
    nymanjens committed with cpovirk Feb 27, 2017
Commits on Feb 24, 2017
  1. Also add Iterable handles for FieldScope APIs to the ProtoSubject cla…

    …sses and fluent interfaces.
    
    Also copy docs instead of using @see to be consistent with the rest of the docs.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=148427848
    torquestomp committed with cpovirk Feb 24, 2017
  2. Deprecate PrimitiveFloatArraySubject.hasValuesWithin, and hide it int…

    …ernally.
    
    There are no usages known to codesearch at time of submission.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=148349271
    PeteGillinGoogle committed with cpovirk Feb 23, 2017
  3. Deprecate PrimitiveDoubleArraySubject.hasValuesWithin, and hide it in…

    …ternally.
    
    There are no usages known to codesearch at time of submission.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=148349080
    PeteGillinGoogle committed with cpovirk Feb 23, 2017
  4. Allow using Iterables for field numbers and field descriptors with th…

    …e FieldScope APIs.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=148303168
    torquestomp committed with cpovirk Feb 23, 2017
Commits on Feb 23, 2017
  1. Bring the truth deps up to date

    Also, remove the "truth.version" property and explicit version setting in the extensions.  They should be relying on ${project.version} so as to ensure that when the project's version is updated, it inherits this value as the version of truth upon which it also depends.  This should avoid any future occasions where we publish a release version with a dependency on a truth SNAPSHOT version.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=148281908
    cgruber committed Feb 23, 2017
  2. Include hex string in byte[] outputs when isEqualTo fails.

    #239
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=148148598
    kluever committed with cgruber Feb 21, 2017
Commits on Feb 21, 2017
  1. Convert the iterableSubject() method on the double[] and float[] subj…

    …ects to use a ternary, to match the change suggested in the review of 6db4d3f for the other array subjects.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=148101165
    PeteGillinGoogle committed with cpovirk Feb 21, 2017
  2. Make the asList() methods of the various primitive & object array sub…

    …jects obey named().
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=148074128
    PeteGillinGoogle committed with cpovirk Feb 21, 2017
  3. Adding a containsCell and doesNotContainCell method that take a cell …

    …directly. Sometimes it's useful to have a helper generate the cell itself and pass that to the assertion than have 3 helpers for generating each part.
    
    Could maybe also call the methods contains() and doesNotContain() but I would be wary of "table-of-tables" situations.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=148033368
    hagbard committed with cpovirk Feb 20, 2017
  4. Make usingTolerance() and usingExactEquality() on PrimitiveDoubleArra…

    …ySubject and PrimitiveFloatArraySubject obey named(), which they didn't previously. And make RelabeledSubjectsTest test this instead of testing the to-be-deprecated hasValuesWithin.
    
    (I note in passing that hasValuesWithin appeared to implement named() wrong because it replaces rather than prepends the array value. I don't plan to fix that for obvious reasons.)
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=147865680
    PeteGillinGoogle committed with cpovirk Feb 17, 2017
Commits on Feb 16, 2017
  1. Deprecate ThrowableSubject.hasMessage(String)

    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=147265097
    kluever committed with ronshapiro Feb 12, 2017
Commits on Feb 10, 2017
  1. Implement MultimapWithProtoValuesSubject. Also update docs.

    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=146522642
    torquestomp committed with cpovirk Feb 3, 2017
  2. Clean up a few internal Throwable assertions.

    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=146405245
    dimo414 committed with cpovirk Feb 2, 2017
  3. Undeprecate and implement the one-arg isEqualTo and isNotEqualTo on P…

    …rimitiveFloatArraySubject. This is to [] as double is to float.
    
    Also did a couple of javadoc fixes on the double side, as we weren't consistent between the one-arg and two-arg overloads (and the two-arg ones confusingly didn't mention the tolerance). Plus, it's no longer true that we deprecate some common methods, so remove that from the class-level docs.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=146386170
    PeteGillinGoogle committed with cpovirk Feb 2, 2017
  4. Undeprecate and implement the one-arg isEqualTo and isNotEqualTo on P…

    …rimitiveDoubleArraySubject.
    
    This is proposal 1 approved in API review []
    The implementation is copied from the other Primitive.*ArraySubjects.
    
    The javadoc is stolen from those and from DoubleSubject and for usingExactEquality for the boilerplate caveats.
    
    Float equivalent to follow.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=146261715
    PeteGillinGoogle committed with cpovirk Feb 1, 2017
  5. TravisCI: Cache downloaded Maven dependencies

    Fixes #232
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=146160856
    pianoben committed with cpovirk Jan 31, 2017
  6. Add comments to some empty catch blocks in Primitive.*ArraySubject.is…

    …NotEqualTo to fix the warnings. Also add the javadoc for those methods (it was missing and the semantic is worth describing) and fix an error in the javadoc of .isEqualTo (which claimed that expected was an Object[] when it isn't).
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=146147489
    PeteGillinGoogle committed with cpovirk Jan 31, 2017
Commits on Jan 31, 2017
  1. Disambiguate OptionalSubject.hasValue() error message when actual and…

    … expected have equal toString's.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=146133517
    dimo414 committed with cpovirk Jan 31, 2017