-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detector CVE-2021-3129 #120
Detector CVE-2021-3129 #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of coder review. I mostly focused on code styles and other obvious issues. Detection logic hasn't been checked yet.
...ce/cve20213129/src/main/java/com/google/tsunami/plugins/example/Cve20213129VulnDetector.java
Outdated
Show resolved
Hide resolved
...ce/cve20213129/src/main/java/com/google/tsunami/plugins/example/Cve20213129VulnDetector.java
Outdated
Show resolved
Hide resolved
...ce/cve20213129/src/main/java/com/google/tsunami/plugins/example/Cve20213129VulnDetector.java
Outdated
Show resolved
Hide resolved
...ce/cve20213129/src/main/java/com/google/tsunami/plugins/example/Cve20213129VulnDetector.java
Outdated
Show resolved
Hide resolved
...ce/cve20213129/src/main/java/com/google/tsunami/plugins/example/Cve20213129VulnDetector.java
Outdated
Show resolved
Hide resolved
...ce/cve20213129/src/main/java/com/google/tsunami/plugins/example/Cve20213129VulnDetector.java
Outdated
Show resolved
Hide resolved
...ce/cve20213129/src/main/java/com/google/tsunami/plugins/example/Cve20213129VulnDetector.java
Outdated
Show resolved
Hide resolved
...ce/cve20213129/src/main/java/com/google/tsunami/plugins/example/Cve20213129VulnDetector.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/google/tsunami/plugins/example/Cve20213129VulnDetectorBootstrapModule.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/google/tsunami/plugins/example/Cve20213129VulnDetectorBootstrapModule.java
Outdated
Show resolved
Hide resolved
@magl0 Thanks a lot for the style suggestions. For now style wise everything should (hopefully) check out :) . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the inline comments, can you please also:
- Migrate the detector code to
community/detectors
? Just to be consistent with the rest of the repo. - Can you please also update the
community/README.md
file and add a link to this detector code?
.../main/java/com/google/tsunami/plugins/detectors/rce/cve20213129/Cve20213129VulnDetector.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/tsunami/plugins/detectors/rce/cve20213129/Cve20213129VulnDetector.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/tsunami/plugins/detectors/rce/cve20213129/Cve20213129VulnDetector.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/tsunami/plugins/detectors/rce/cve20213129/Cve20213129VulnDetector.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/tsunami/plugins/detectors/rce/cve20213129/Cve20213129VulnDetector.java
Outdated
Show resolved
Hide resolved
...google/tsunami/plugins/detectors/rce/cve20213129/Cve20213129VulnDetectorBootstrapModule.java
Outdated
Show resolved
Hide resolved
...t/java/com/google/tsunami/plugins/detectors/rce/cve20213129/Cve20213129VulnDetectorTest.java
Outdated
Show resolved
Hide resolved
Ready for another round :) |
Code style looking good now. We'll start verifying the payload and tests. |
This is still under code reviews and payload verification process from a third eye in the Tsunami scanner team. Once it passes we'll merge the pull request. We'll let you know if we found additional issues. |
Hey Google Tsunami Team,
my PR for the Vuln Detector Plugin for CVE-2021-3129 (see Issue #86)
I used the following docker images to verify the vulnerability. I should note that I made my own images as I couldn't get the official
bitnami/laravel
images to run without also requiring a db server for the startup. Also, the bitnami/laravel:8.4.2 docker image, which you would expect to be vulnerable to CVE-2021-3129, is not vulnerable as it builds with a patched dependency offacade/ignition
. (However, any servers build before the facade/ignition patch are still vulnerable).Vulnerable image:
Safe image:
Happy to hear your feedback :)