From 871f50d2ca8208ff538b1f7e5d0087b01e912b05 Mon Sep 17 00:00:00 2001 From: nelson-brochado Date: Wed, 30 Aug 2017 16:03:29 +0200 Subject: [PATCH 1/2] Fixed a bug in Tuple7: implementation of operator == was buggy. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Adding myself as an author to this project (given that I contributed to it by fixing a bug). - Modified the README to be more explicit regarding the API of this library. - Changed homepage field in pubspec.yml to point to Dart organisation’s version of the same library. --- .gitignore | 2 ++ AUTHORS | 1 + README.md | 2 +- lib/src/tuple.dart | 4 ++-- lib/tuple.dart | 2 +- pubspec.yaml | 3 ++- 6 files changed, 9 insertions(+), 5 deletions(-) diff --git a/.gitignore b/.gitignore index c944841..7a0eba4 100644 --- a/.gitignore +++ b/.gitignore @@ -26,3 +26,5 @@ doc # Mac .DS_Store + +.atom/ diff --git a/AUTHORS b/AUTHORS index d653058..d91d631 100644 --- a/AUTHORS +++ b/AUTHORS @@ -6,3 +6,4 @@ Boris Kaul Kwang Yul Seo +Nelson Brochado diff --git a/README.md b/README.md index 61c0db1..0fe1243 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # Tuple data structure -- [Tuple2], [Tuple3]... +- [Tuple2], [Tuple3], [Tuple4], [Tuple5], [Tuple6], [Tuple7] [![Build Status](https://travis-ci.org/kseo/tuple.svg)](https://travis-ci.org/kseo/tuple) [![Coverage Status](https://coveralls.io/repos/kseo/tuple/badge.svg?branch=master&service=github)](https://coveralls.io/github/kseo/tuple?branch=master) diff --git a/lib/src/tuple.dart b/lib/src/tuple.dart index 2dace3f..eeb86f7 100644 --- a/lib/src/tuple.dart +++ b/lib/src/tuple.dart @@ -465,8 +465,8 @@ class Tuple7 { o.item3 == item3 && o.item4 == item4 && o.item5 == item5 && - o.item5 == item6 && - o.item6 == item7; + o.item6 == item6 && + o.item7 == item7; @override int get hashCode => hashObjects([ diff --git a/lib/tuple.dart b/lib/tuple.dart index 115d8af..3734fb8 100644 --- a/lib/tuple.dart +++ b/lib/tuple.dart @@ -4,7 +4,7 @@ /// # Tuple data structure /// -/// - [Tuple2], [Tuple3]... +/// - [Tuple2], [Tuple3], [Tuple4], [Tuple5], [Tuple6], [Tuple7] /// /// ## Usage example /// diff --git a/pubspec.yaml b/pubspec.yaml index d60177c..eaa080b 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -3,8 +3,9 @@ version: 1.0.1 authors: - Boris Kaul - Kwang Yul Seo +- Nelson Brochado description: Tuple data structure -homepage: https://github.com/kseo/tuple +homepage: https://github.com/dart-lang/tuple environment: sdk: '>=1.6.0' dependencies: From 7979822376afecd748d7219027fd1da5e3809824 Mon Sep 17 00:00:00 2001 From: nelson-brochado Date: Wed, 30 Aug 2017 16:13:29 +0200 Subject: [PATCH 2/2] Changed the version of this library to 1.0.2 - Added an entry to CHANGELOG.md to reflect new version and updates --- CHANGELOG.md | 3 +++ pubspec.yaml | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 77d2a47..b0e18ec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,6 @@ +#### 1.0.2 + * Fixed a bug in Tuple7: implementation of operator == was buggy. + #### 1.0.1 * Fix all strong-mode warnings and errors. diff --git a/pubspec.yaml b/pubspec.yaml index eaa080b..8188863 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,5 +1,5 @@ name: tuple -version: 1.0.1 +version: 1.0.2 authors: - Boris Kaul - Kwang Yul Seo