New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Plaso only for workers #183

Merged
merged 4 commits into from Jun 20, 2018

Conversation

Projects
None yet
2 participants
@berggren
Collaborator

berggren commented Jun 6, 2018

This PR remove the dependency on Plaso for the client only install. If you are installing a worker you now need to do: pip install turbinia[worker]

Also, this PR fixes a bug where pip v10.x couldn install the package.

@berggren berggren self-assigned this Jun 6, 2018

@berggren berggren requested a review from aarontp Jun 6, 2018

@aarontp

aarontp approved these changes Jun 6, 2018

LGTM

@aarontp

This comment has been minimized.

Show comment
Hide comment
@aarontp

aarontp Jun 7, 2018

Member

So, actually after going through the other open PR, I think we might want to change this around a bit. See #184 for my proposal. We don't have to implement the whole proposal, but maybe we can change this to 'gcp-worker' instead of 'worker'? And then in the other open PR we can do the rest of the changes?

Member

aarontp commented Jun 7, 2018

So, actually after going through the other open PR, I think we might want to change this around a bit. See #184 for my proposal. We don't have to implement the whole proposal, but maybe we can change this to 'gcp-worker' instead of 'worker'? And then in the other open PR we can do the rest of the changes?

@berggren

This comment has been minimized.

Show comment
Hide comment
@berggren

berggren Jun 19, 2018

Collaborator

@aarontp PTAL - I cleaned up setup.py a bit.

Collaborator

berggren commented Jun 19, 2018

@aarontp PTAL - I cleaned up setup.py a bit.

@aarontp

This comment has been minimized.

Show comment
Hide comment
@aarontp

aarontp Jun 20, 2018

Member

Awesome, looks good: Thank you for cleaning up the rest of that file too. I should have merged this one before #186, but I'll just manually fix the conflict and merge this.

Member

aarontp commented Jun 20, 2018

Awesome, looks good: Thank you for cleaning up the rest of that file too. I should have merged this one before #186, but I'll just manually fix the conflict and merge this.

@aarontp aarontp merged commit 60676c8 into master Jun 20, 2018

1 check passed

cla/google All necessary CLAs are signed

@aarontp aarontp deleted the plaso-for-workers-only branch Jun 20, 2018

@aarontp aarontp referenced this pull request Jun 20, 2018

Closed

Update setup.py #39

aarontp added a commit that referenced this pull request Jun 29, 2018

Install Plaso only for workers (#183)
* Add support for pip 10 and add worker install target

* Worker extras

* More setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment