Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAPF run 2 #299

Merged
merged 2 commits into from Nov 14, 2018
Merged

YAPF run 2 #299

merged 2 commits into from Nov 14, 2018

Conversation

@aarontp
Copy link
Member

aarontp commented Nov 10, 2018

This moves the yapf config, adds the SPLIT_BEFORE_NAMED_ASSIGNS, and re-runs yapf. This is an updated version of #255, but I'm keeping that around for now since it has my comments on this version of the yapf config.

aarontp added 2 commits Nov 10, 2018
@aarontp aarontp changed the title YAPF run 1.1 YAPF run 2 Nov 10, 2018
@aarontp aarontp requested a review from Onager Nov 10, 2018
@aarontp

This comment has been minimized.

Copy link
Member Author

aarontp commented Nov 10, 2018

LMK what you think of these changes. I started this in a new PR and left the original (#255) for now to keep my original comments (many of which are still relevant). The more recent versions of YAPF fixed some of the more egregiously bad formatting changes, but there is still a bit of ugliness in there. As a whole I think there's more good than bad though, so I think we can use this and move forward and tune things later.

FYI: @berggren

@Onager
Onager approved these changes Nov 14, 2018
@Onager Onager merged commit 8b3b923 into master Nov 14, 2018
4 checks passed
4 checks passed
CodeFactor No issues found.
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Onager Onager deleted the yapf2 branch Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.