Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed python3 logging errors. #458

Merged
merged 22 commits into from Dec 5, 2019
Merged

Fixed python3 logging errors. #458

merged 22 commits into from Dec 5, 2019

Conversation

@alimez
Copy link
Collaborator

alimez commented Nov 7, 2019

This should take care of the errors caused by Py3 handling None type.

Ali Memarzia added 2 commits Nov 7, 2019
Ali Memarzia
Ali Memarzia
@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 7, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@alimez

This comment has been minimized.

Copy link
Collaborator Author

alimez commented Nov 12, 2019

@googlebot I fixed it.

Copy link
Member

aarontp left a comment

Thanks for the PR.

turbinia/output_manager.py Outdated Show resolved Hide resolved
@aarontp

This comment has been minimized.

Copy link
Member

aarontp commented Nov 19, 2019

@googlebot : PTAL

alimez added 8 commits Nov 19, 2019
…mmand + implemented realtime status of queued or running tasks
@aarontp

This comment has been minimized.

Copy link
Member

aarontp commented Nov 19, 2019

Hey, FYI, it looks like you also pushed your other branch working on task updates into this one. Was that intentional? It looks like there are some formatting things that YAPF doesn't like. Could you run yapf with the .style.yapf config that is in the root directory of the project to make sure things are formatted correctly? The exact invocation is in the output of the yapf test when you run run_tests.py.

@alimez

This comment has been minimized.

Copy link
Collaborator Author

alimez commented Nov 20, 2019

Hey, FYI, it looks like you also pushed your other branch working on task updates into this one. Was that intentional? It looks like there are some formatting things that YAPF doesn't like. Could you run yapf with the .style.yapf config that is in the root directory of the project to make sure things are formatted correctly? The exact invocation is in the output of the yapf test when you run run_tests.py.

I removed the task update from this PR.

alimez added 2 commits Nov 20, 2019
turbinia/workers/__init__.py Outdated Show resolved Hide resolved
turbinia/turbiniactl.py Outdated Show resolved Hide resolved
@@ -123,10 +121,8 @@ def __str__(self):

def setup(self, task):
"""Handles initializing task based attributes, after object creation.

This comment has been minimized.

Copy link
@aarontp

aarontp Nov 20, 2019

Member

Strange, I guess YAPF removed all of these newlines?

This comment has been minimized.

Copy link
@aarontp

aarontp Nov 21, 2019

Member

Could you confirm whether YAPF changed these newlines? YAPF seems to be passing, but it doesn't match the rest of the codebase so I'm a little confused. There are other open PRs with tests passing that don't have these changes, so maybe YAPF doesn't actually care about them? The style guide (and rest of the code base) generally shows having blank lines between the different sections, so I'd prefer to keep them if YAPF isn't forcing us to change them:
http://google.github.io/styleguide/pyguide.html#doc-function-raises

alimez and others added 6 commits Nov 21, 2019
Code looks cleaner this way.

Co-Authored-By: Aaron Peterson <aaronp@gmail.com>
Co-Authored-By: Aaron Peterson <aaronp@gmail.com>
@aarontp
aarontp approved these changes Dec 5, 2019
Copy link
Member

aarontp left a comment

LGTM, thanks!

@aarontp aarontp merged commit 8558801 into google:master Dec 5, 2019
1 of 2 checks passed
1 of 2 checks passed
cla/google Need a CLA for one or more commit authors
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alimez alimez deleted the alimez:dev1 branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.