Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evidence path to metadata file #501

Merged
merged 2 commits into from Feb 10, 2020
Merged

Add evidence path to metadata file #501

merged 2 commits into from Feb 10, 2020

Conversation

@aarontp
Copy link
Member

aarontp commented Feb 10, 2020

This is so we don't have to infer the path from the metadata file location and name, and the Timesketch GCS importer can read it from the json file.

@aarontp aarontp requested a review from berggren Feb 10, 2020
@aarontp

This comment has been minimized.

Copy link
Member Author

aarontp commented Feb 10, 2020

@berggren: This should be good to review now; I fixed the tests.

Copy link
Collaborator

berggren left a comment

LGTM

@aarontp aarontp merged commit 725412f into master Feb 10, 2020
3 checks passed
3 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@aarontp aarontp deleted the metadata-path-add branch Feb 10, 2020
aarontp added a commit that referenced this pull request Feb 12, 2020
* add evidence path to metadata file

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.