Fix vroom tests to not depend on executables installed on host #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My first attempt (2f55a17) kept the mess contained in the vroom files, but was really, really nasty. I could go either way, but I'm leaning towards the codefmt#DisableIsAvailableChecksForTesting helper approach. |
dbarnett
force-pushed
the
tests
branch
2 times, most recently
from
430154c to
4789353
Compare
|
LGTM. 3d90013 is much nicer. |
dbarnett
added a commit
that referenced
this pull request
Jan 24, 2015
Fix vroom tests to not depend on executables installed on host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7.