Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small change to make golint slightly happier. #36

Merged
merged 1 commit into from Feb 4, 2020
Merged

Small change to make golint slightly happier. #36

merged 1 commit into from Feb 4, 2020

Conversation

@yuizumi
Copy link
Collaborator

yuizumi commented Feb 3, 2020

No description provided.

@yuizumi yuizumi requested a review from tomokinat Feb 3, 2020
@tomokinat

This comment has been minimized.

Copy link
Collaborator

tomokinat commented Feb 3, 2020

Are you thinking about adding golint to CI?

@yuizumi

This comment has been minimized.

Copy link
Collaborator Author

yuizumi commented Feb 4, 2020

No ― it reports a couple of "issues" I don't want to fix (e.g. golint insists validate.ValidateURLRule should be named validate.URLRule but it makes the code less clear in my opinion).

@tomokinat

This comment has been minimized.

Copy link
Collaborator

tomokinat commented Feb 4, 2020

Ack.

@yuizumi yuizumi merged commit 6ea533e into master Feb 4, 2020
7 checks passed
7 checks passed
check-format
Details
check-format
Details
go-vet
Details
go-vet
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@yuizumi yuizumi deleted the yz.lint branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.