Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign preload.Preload as a struct. #39

Merged
merged 1 commit into from Feb 5, 2020
Merged

Redesign preload.Preload as a struct. #39

merged 1 commit into from Feb 5, 2020

Conversation

@yuizumi
Copy link
Collaborator

yuizumi commented Feb 5, 2020

The new design allows Preloads to be compared by cmp.Equal/cmp.Diff. It also simplifies adding new Resources to an existing Preload, e.g. for variants support.

The new design allows Preloads to be compared by cmp.Equal/cmp.Diff.
It also simplifies adding new Resources to an existing Preload, e.g. for
variants support.
@yuizumi yuizumi requested a review from tomokinat Feb 5, 2020
*httplink.Link

// Resources contains a set of resources referenced by the preload link.
// It typically consists just of one resource, but contains multiple

This comment has been minimized.

Copy link
@tomokinat

tomokinat Feb 5, 2020

Collaborator

s/It/Resources maybe?

This comment has been minimized.

Copy link
@yuizumi

yuizumi Feb 5, 2020

Author Collaborator

I meant rather "the set of resources," so probably no. The meaning is the same whether "it" refers to Resources or the set of resources, so I leave it unchanged.

@yuizumi yuizumi merged commit 596f13d into master Feb 5, 2020
7 checks passed
7 checks passed
check-format
Details
check-format
Details
go-vet
Details
go-vet
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@yuizumi yuizumi deleted the yz.preload branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.