Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upExplicitly require wgxpath.DataType #54
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
googlebot
Nov 26, 2017
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
- If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
- In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.
googlebot
commented
Nov 26, 2017
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed, please reply here (e.g.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I signed it! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
googlebot
commented
Nov 26, 2017
|
CLAs look good, thanks! |
corevo commentedNov 26, 2017
Loading the library through closure-loader fails due to wgxpath.DataType not being required.
It causes wgxpath.DataType to be undefined.