Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/wire: factor out common code in solve #98

Merged
merged 4 commits into from
Dec 14, 2018
Merged

internal/wire: factor out common code in solve #98

merged 4 commits into from
Dec 14, 2018

Conversation

shantuo
Copy link
Contributor

@shantuo shantuo commented Dec 12, 2018

  • Fixed a bug when a interface is bind to a value wire would fail to record it is used.
  • Also rename ProvidedType.ConcreteType to Type since it doesn't necessarily returns a concrete type.

Fixes #72

@go-cloud-bot
Copy link

go-cloud-bot bot commented Dec 12, 2018

Please edit the title of this pull request with the name of the affected package, or "all", followed by a colon, followed by a short summary of the change. Example: blob/gcsblob: improve comments.

@googlebot googlebot added the cla: yes Google CLA has been signed! label Dec 12, 2018
@shantuo shantuo changed the title Factor out common code in solve internal/wire: factor out common code in solve Dec 12, 2018
zombiezen
zombiezen reviewed Dec 13, 2018
View reviewed changes
Copy link
Collaborator

@zombiezen zombiezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring LGTM, but let's clarify the ConcreteType method first.

internal/wire/testdata/BindInterfaceWithValue/want/program_out.txt Outdated Show resolved Hide resolved
internal/wire/parse.go Outdated Show resolved Hide resolved
@shantuo
Copy link
Contributor Author

shantuo commented Dec 14, 2018

PTAL

@zombiezen zombiezen merged commit 4243b01 into google:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombiezen zombiezen zombiezen approved these changes

Assignees

@zombiezen zombiezen

Labels
cla: yes Google CLA has been signed!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shantuo @zombiezen @googlebot