Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove illegal `-f' ar option on Darwin #72

Merged
merged 1 commit into from Oct 5, 2017

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Feb 12, 2017

This PR fixes compilation error on macOS 10.12

ar crf src/convert_woff2ttf_fuzzer.a  src/font.o  src/glyph.o  src/normalize.o  src/table_tags.o  src/transform.o  src/woff2_dec.o  src/woff2_enc.o  src/woff2_common.o  src/woff2_out.o  src/variable_length.o brotli/enc/*.o brotli/dec/*.o src/convert_woff2ttf_fuzzer.o
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ar: illegal option -- f
usage:  ar -d [-TLsv] archive file ...
	ar -m [-TLsv] archive file ...
	ar -m [-abiTLsv] position archive file ...
	ar -p [-TLsv] archive [file ...]
	ar -q [-cTLsv] archive file ...
	ar -r [-cuTLsv] archive file ...
	ar -r [-abciuTLsv] position archive file ...
	ar -t [-TLsv] archive [file ...]
	ar -x [-ouTLsv] archive [file ...]
make: *** [convert_woff2ttf_fuzzer] Error 1

man ar suggests there is no -f option on ar.

This PR removes -f option to make it work on macOS. I am not sure if this option is vital on building process so any suggestions are welcome.

@dmitshur
Copy link
Member

PR title says r, but it's actually f.

The corresponding issue is #73.

@JLHwung
Copy link
Contributor Author

JLHwung commented Jul 24, 2017

@shurcooL Good catch! corrected the PR title.

@JLHwung JLHwung changed the title remove illegal `-r' ar option on Darwin remove illegal `-f' ar option on Darwin Jul 24, 2017
@rsheeter rsheeter merged commit 914faa3 into google:master Oct 5, 2017
@rsheeter
Copy link
Contributor

rsheeter commented Oct 5, 2017

Thanks!

@JLHwung JLHwung deleted the fix-macos-compilation-error branch October 6, 2017 03:58
@JLHwung
Copy link
Contributor Author

JLHwung commented Oct 6, 2017

You are very welcome.

anthrotype referenced this pull request in source-foundry/Hack Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants