Fix SPLIT_ARGUMENTS_WHEN_COMMA_TERMINATED for one-item named argument list#1160
Merged
bwendling merged 2 commits intogoogle:mainfrom Oct 10, 2023
Conversation
alexey-pelykh
force-pushed
the
fix/split_arguments_when_comma_terminated-single-named-argument
branch
from
408e49d to
b5597a0
Compare
Contributor
Author
|
@bwendling @Spitfire1900 a follow-up to #1142, yet while tests aren't failing, I'm not sure that this shuffling of code location is correct |
… lists by taking precedence over SPLIT_BEFORE_NAMED_ASSIGNS
alexey-pelykh
force-pushed
the
fix/split_arguments_when_comma_terminated-single-named-argument
branch
from
b5597a0 to
98916b7
Compare
Spitfire1900
approved these changes
Oct 7, 2023
bwendling
approved these changes
Oct 10, 2023
…ngle-named-argument
alexey-pelykh
deleted the
fix/split_arguments_when_comma_terminated-single-named-argument
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by taking precedence over SPLIT_BEFORE_NAMED_ASSIGNS:
Turn
into