Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darwin builds? #3

Open
wants to merge 2 commits into
base: master
from

Conversation

@kanterov
Copy link

commented May 23, 2019

I see that you are not accepting code contributions. You can see it more as proposal or question.

I did a few tweaks to build files and the source code to build on Mac, and it seems to work. I'm wondering what you think about having Mac builds. I hope you (or somebody else) will find this patch useful.

@googlebot

This comment has been minimized.

Copy link

commented May 23, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label May 23, 2019
@apilloud

This comment has been minimized.

Copy link
Member

commented May 24, 2019

Hi Gleb! We are interested in supporting other platforms, so thanks for doing this! While we aren't ready to accept external patches yet we can keep this open as a feature request until we can.

@kanterov kanterov force-pushed the kanterov:darwin-build branch from 1a5d5dc to fcc91a2 Aug 2, 2019
@kanterov

This comment has been minimized.

Copy link
Author

commented Aug 2, 2019

Updated and rebased on the latest master.

kanterov added 2 commits Aug 2, 2019
@kanterov kanterov force-pushed the kanterov:darwin-build branch from fcc91a2 to f4bf2b2 Oct 21, 2019
@kanterov

This comment has been minimized.

Copy link
Author

commented Oct 21, 2019

Updated and rebased on the latest master. I had to hack source_location because my version of clang doesn't have the necessary builtins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.