Properly specify prerequisites in Makefile #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, prerequisites for some targets were implicit in nature, meaning that whether the library targets actually attempted to link with object files compiled with -fPIC depended on the leftover files from previous build and the order in which targets were built. This could lead to build failures for the libraries, and the standalone utilities may have been able to be linked with object files compiled with position independent code. Furthermore, a target "all" was added to build all targets, and the phony targets were properly set to "all" and "clean". This fixes issue google#68.
This project doesn't use libtool, and libtool itself explicitly states one should not make any assumption about the structure of .lo files. Didn't see this one before I opened mine. Oh well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, prerequisites for some targets were implicit in nature, meaning that whether the library targets actually attempted to link with object files compiled with -fPIC depended on the leftover files from previous build and the order in which targets were built.
This could lead to build failures for the libraries, and the standalone utilities may have been able to be linked with object files compiled with position independent code.
Furthermore, a target "all" was added to build all targets, and the phony targets were properly set to "all" and "clean".
This fixes issue #68.