New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AIP number in rule register function. #330
Conversation
This PR removes >500 lines of duplicated codes :) |
I think this PR would drop coverage in the rule modules below 100%, would it not? |
I just realized we never try to catch errors when registering a rule (see this example). In other words, |
The coverage is back to 100%. But we need to fix the meta_linter. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the AddRules
pattern may have been an error. We can always change it later, but this is an incremental improvement.
+1 |
Rule registering now requires a valid AIP number. It removes the redundant tests in each rule package testing if a rule is in the right group.