Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: regenerate #151

Merged
merged 6 commits into from Oct 16, 2019
Merged

feat: regenerate #151

merged 6 commits into from Oct 16, 2019

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Oct 10, 2019

v2 and v2beta1

  • Add set_agent and delete_agent methods to AgentsClient
  • Add api_version and tier to Agents
  • Add session_entity_types to WebhookResponse
  • Add model_variant and single_utterance to InputAudioConfig
  • Add SpeechModelVariant enum
  • Add enable_fuzzy_extraction to EntityType
  • Add KIND_REGEXP to EntityType.Kind enum
  • Add client_options to clients
  • Allow kwargs to be passed to transport create_channel methods
  • Deprecate single_utterance attribute in StreamingDetectIntentRequest. Please use InputAudioConfig.single_utterance

v2

  • Add Google Hangouts to Message.Platform enum

v2beta1

  • Add get_validation_result method to AgentsClient
  • Add gcs_source and source to reload_document method in DocumentsClient
  • Add Rich Business Messaging (RBM) support, table_card, and media_content to intent messages
  • Add enable_word_info, speech_contexts to InputAudioConfig
  • update_document returns _OperationFuture rather than Operation
  • Deprecate projects.agent.knowledgeBases. Please use projects.knowledgeBases.
  • Add stability, speech_word_info and speech_end_offset to StreamingRecognitionResult
@googlebot googlebot added the cla: yes label Oct 10, 2019
Copy link
Contributor Author

@busunkim96 busunkim96 left a comment

These are notes I took for myself as I went through the diff.

# Setup Request
knowledge_base = {}

response = client.update_knowledge_base(knowledge_base)
Comment on lines +233 to +236

This comment has been minimized.

@busunkim96

busunkim96 Oct 11, 2019
Author Contributor

Passes empty knowledge_base in UpdateKnowledgeBaseRequest.

@@ -118,11 +112,12 @@ def test_get_entity_type(self):
# Setup Expected Response
name_2 = 'name2-1052831874'
display_name = 'displayName1615086568'
expected_response = {'name': name_2, 'display_name': display_name}
enable_fuzzy_extraction = True

This comment has been minimized.

@busunkim96

busunkim96 Oct 11, 2019
Author Contributor

Add enable_fuzzy_extraction

"""Accesses the google.cloud.dialogflow.v2 Agents API."""

import functools
import pkg_resources
import warnings

from google.oauth2 import service_account
import google.api_core.client_options

This comment has been minimized.

@busunkim96

busunkim96 Oct 11, 2019
Author Contributor

Add client_options to v2

This comment has been minimized.

@nnegrey

nnegrey Oct 16, 2019
Contributor

So client_options are basically a way to set the endpoint directly?

retry=google.api_core.gapic_v1.method.DEFAULT,
timeout=google.api_core.gapic_v1.method.DEFAULT,
metadata=None):
def set_agent(

This comment has been minimized.

@busunkim96

busunkim96 Oct 11, 2019
Author Contributor

Add set_agent and delete_agent to v2.

@@ -111,6 +112,50 @@ class OutputAudioEncoding(enum.IntEnum):
OUTPUT_AUDIO_ENCODING_OGG_OPUS = 3


class SpeechModelVariant(enum.IntEnum):

This comment has been minimized.

@busunkim96

busunkim96 Oct 11, 2019
Author Contributor

Add SpeechModelVariant enum to v2

language.
enable_word_info:

This comment has been minimized.

@busunkim96

busunkim96 Oct 11, 2019
Author Contributor

Add enable_word_info, speech_contexts, model_variant, single_utterance to InputAudioConfig (v2beta1)

is of the form: gs://bucket/object-prefix-or-name Whether a
prefix or name is used depends on the use case.
""",
# @@protoc_insertion_point(class_scope:google.cloud.dialogflow.v2beta1.GcsSource)

This comment has been minimized.

@busunkim96

busunkim96 Oct 11, 2019
Author Contributor

Add GcsSource to v2beta1

@@ -2575,6 +3204,266 @@
# @@protoc_insertion_point(class_scope:google.cloud.dialogflow.v2beta1.Intent.Message.TelephonyTransferCall)
))
,

This comment has been minimized.

@busunkim96

busunkim96 Oct 11, 2019
Author Contributor

Add Rich Business Messaging support to intent message (v2beta1)

@@ -2615,6 +3504,14 @@
Synthesizes speech in Telephony Gateway.
telephony_transfer_call:
Transfers the call in Telephony Gateway.
rbm_text:

This comment has been minimized.

@busunkim96

busunkim96 Oct 11, 2019
Author Contributor

Add rbm_text, rbm_standalone_rich_card, rbm_standalone_rich_card to Intent.Message (v2beta1)

error_message:
The detailed error messsage.
""",
# @@protoc_insertion_point(class_scope:google.cloud.dialogflow.v2beta1.ValidationError)

This comment has been minimized.

@busunkim96

busunkim96 Oct 11, 2019
Author Contributor

Add ValidationError, ValidationResult to v2beta1

@@ -1218,8 +1135,10 @@
form of text, or 3. an event that specifies which intent to
trigger.
single_utterance:
Optional. If ``false`` (default), recognition does not cease
until the client closes the stream. If ``true``, the
DEPRECATED. Please use [InputAudioConfig.single\_utterance][go

This comment has been minimized.

@busunkim96

busunkim96 Oct 11, 2019
Author Contributor

Deprecate single_utterance in StreamingDetectIntentrequest

@busunkim96 busunkim96 requested a review from nnegrey Oct 11, 2019
@busunkim96 busunkim96 force-pushed the fix-synth branch from 5736f59 to 7ccdff4 Oct 11, 2019
busunkim96 added 4 commits Oct 10, 2019
@busunkim96 busunkim96 force-pushed the fix-synth branch from 7151d56 to 64a9ae8 Oct 14, 2019
busunkim96 added 2 commits Oct 15, 2019
@busunkim96
Copy link
Contributor Author

@busunkim96 busunkim96 commented Oct 15, 2019

@nnegrey Please review/merge when you are ready.

input. When this field is set, Dialogflow ignores the
``fulfillment_text``, ``fulfillment_messages``, and
``payload`` fields.
session_entity_types:

This comment has been minimized.

@busunkim96

busunkim96 Oct 15, 2019
Author Contributor

Add session_entity_types to WebhookResponse

@@ -1488,6 +1545,24 @@
was not set. This field is typically only provided if
``is_final`` is true and you should not rely on it being
accurate or even set.
stability:

This comment has been minimized.

@busunkim96

busunkim96 Oct 15, 2019
Author Contributor

Add stability, speech_word_info and speech_end_offset to StreamingRecognitionResult

@@ -821,6 +834,9 @@
entities:
Optional. The collection of entity entries associated with the
entity type.
enable_fuzzy_extraction:

This comment has been minimized.

@busunkim96

busunkim96 Oct 15, 2019
Author Contributor

Add enable_fuzzy_extraction to EntityType


syntax = "proto3";

package google.cloud.dialogflow.v2;

This comment has been minimized.

@nnegrey

nnegrey Oct 16, 2019
Contributor

Removing .proto files, because they exist in googleapis, yes?

Copy link
Contributor

@nnegrey nnegrey left a comment

LGTM

@nnegrey nnegrey merged commit 6222277 into master Oct 16, 2019
3 checks passed
3 checks passed
Kokoro Build successful
Details
cla/google All necessary CLAs are signed
conventionalcommits.org
Details
@busunkim96 busunkim96 deleted the fix-synth branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.