From dd68dd1f288c4fbbdb7f54900094379ee1d771c0 Mon Sep 17 00:00:00 2001 From: Vadym Matsishevskyi <25311427+vam-google@users.noreply.github.com> Date: Tue, 13 Sep 2022 21:29:18 +0000 Subject: [PATCH] fix: unit test generation for boolean query prams (#1447) Without this fix the current compute engine tests are failing. Also 3 other APIs in googleapis would have failed if grpc+rest transport was enabled on them. --- .../tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 | 2 ++ .../tests/unit/gapic/%name_%version/%sub/test_macros.j2 | 2 ++ 2 files changed, 4 insertions(+) diff --git a/gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 b/gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 index 198efeca78..beeac730a0 100644 --- a/gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 +++ b/gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 @@ -1213,6 +1213,8 @@ def test_{{ method_name }}_rest_required_fields(request_type={{ method.input.ide "{{ req_field.name | camel_case }}", {% if req_field.field_pb.type == 9 %} "{{ req_field.field_pb.default_value }}", + {% elif req_field.field_pb.type == 8 %} + str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}).lower(), {% else %} str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}), {% endif %}{# default is str #} diff --git a/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 b/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 index 0ab177be7b..365f134630 100644 --- a/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 +++ b/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 @@ -1102,6 +1102,8 @@ def test_{{ method_name }}_rest_required_fields(request_type={{ method.input.ide "{{ req_field.name | camel_case }}", {% if req_field.field_pb.type == 9 %} "{{ req_field.field_pb.default_value }}", + {% elif req_field.field_pb.type == 8 %} + str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}).lower(), {% else %} str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}), {% endif %}{# default is str #}