Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker entrypoint syntax error #135

Closed
DaniGuardiola opened this issue Jun 26, 2019 · 3 comments

Comments

Projects
None yet
5 participants
@DaniGuardiola
Copy link

commented Jun 26, 2019

I'm getting this error whenever I run the docker container:

/usr/src/gapic-generator-python/docker-entrypoint.sh: line 38: syntax error near unexpected token `;;'
/usr/src/gapic-generator-python/docker-entrypoint.sh: line 38: `      ;;'

I changed this line to convert the else if into an elif because otherwise the fi for the second if was missing, and that did the trick.

else if [[ $1 == --gapic-* ]]; then

Now I don't understand if I'm doing something wrong (I think I'm not) or if this was not tested, but the currently published version in the Docker Hub does not work for me because of this.

DaniGuardiola added a commit to DaniGuardiola/grpc-client-generator-python that referenced this issue Jun 26, 2019

@software-dov

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

Reproduced and verified. Will push a fix momentarily.

@busunkim96

This comment has been minimized.

Copy link

commented Jul 16, 2019

@software-dov Hi! I just ran into this error (using gcr.io/gapic-images/gapic-generator-python:latest). Has the image been re-published since the fix?

@software-dov

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

Just tagged the 0.11.0 release that should hopefully cause the automation to generate an image with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.