diff --git a/gapic/utils/reserved_names.py b/gapic/utils/reserved_names.py index cf87e8399..40d9301fa 100644 --- a/gapic/utils/reserved_names.py +++ b/gapic/utils/reserved_names.py @@ -25,5 +25,8 @@ keyword.kwlist, # We make SOME exceptions for certain names that collide with builtins. set(dir(builtins)) - {"filter", "map", "id", "input", "property"}, + # "mapping" and "ignore_unknown_fields" have special uses + # in the constructor of proto.Message + {"mapping", "ignore_unknown_fields"}, ) ) diff --git a/tests/unit/samplegen/test_integration.py b/tests/unit/samplegen/test_integration.py index 75ae35ec5..aefde2f1d 100644 --- a/tests/unit/samplegen/test_integration.py +++ b/tests/unit/samplegen/test_integration.py @@ -23,7 +23,7 @@ from gapic.samplegen_utils import (types, utils as gapic_utils) from gapic.schema import (naming, wrappers) -from tests.unit.samplegen.common_types import (DummyField, DummyMessage, +from common_types import (DummyField, DummyMessage, DummyMessageTypePB, DummyMethod, DummyService, DummyIdent, DummyApiSchema, DummyNaming, enum_factory, message_factory) diff --git a/tests/unit/samplegen/test_template.py b/tests/unit/samplegen/test_template.py index 5a4086868..42b8bb2aa 100644 --- a/tests/unit/samplegen/test_template.py +++ b/tests/unit/samplegen/test_template.py @@ -21,7 +21,7 @@ from gapic.samplegen_utils.types import CallingForm from textwrap import dedent -from tests.unit.samplegen import common_types +import common_types def check_template(template_fragment, expected_output, **kwargs): diff --git a/tests/unit/schema/wrappers/test_field.py b/tests/unit/schema/wrappers/test_field.py index 7c9bfacbd..f823104e7 100644 --- a/tests/unit/schema/wrappers/test_field.py +++ b/tests/unit/schema/wrappers/test_field.py @@ -357,6 +357,12 @@ def test_field_name_kword_disambiguation(): ) assert frum_field.name == "frum" + mapping_field = make_field(name="mapping") + assert mapping_field.name == "mapping_" + + ignore_field = make_field(name="ignore_unknown_fields") + assert ignore_field.name == "ignore_unknown_fields_" + def test_field_resource_reference(): field = make_field(name='parent', type='TYPE_STRING')