Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.


feat: update DirectPath environment variables (#1412)
Browse files Browse the repository at this point in the history
Co-authored-by: Vadym Matsishevskyi <>
  • Loading branch information
mohanli-ml and vam-google committed Jun 30, 2021
1 parent 0eac650 commit 4f63b61
Showing 1 changed file with 15 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@
public final class InstantiatingGrpcChannelProvider implements TransportChannelProvider {
private static final String DIRECT_PATH_ENV_DISABLE_DIRECT_PATH =
static final long DIRECT_PATH_KEEP_ALIVE_TIME_SECONDS = 3600;
// reduce the thundering herd problem of too many channels trying to (re)connect at the same time
Expand Down Expand Up @@ -243,17 +245,27 @@ public ManagedChannel createSingleChannel() throws IOException {
return GrpcTransportChannel.create(outerChannel);

// TODO(weiranf): Use attemptDirectPath as the only indicator once setAttemptDirectPath is adapted
// TODO(mohanli): Use attemptDirectPath as the only indicator once setAttemptDirectPath is adapted
// and the env var is removed from client environment.
private boolean isDirectPathEnabled(String serviceAddress) {
String disableDirectPathEnv = envProvider.getenv(DIRECT_PATH_ENV_DISABLE_DIRECT_PATH);
boolean isDirectPathDisabled = Boolean.parseBoolean(disableDirectPathEnv);
if (isDirectPathDisabled) {
return false;
// Only check attemptDirectPath when DIRECT_PATH_ENV_DISABLE_DIRECT_PATH is not set.
if (attemptDirectPath != null) {
return attemptDirectPath;
// Only check DIRECT_PATH_ENV_VAR when attemptDirectPath is not set.
String whiteList = envProvider.getenv(DIRECT_PATH_ENV_VAR);
if (whiteList == null) return false;
if (whiteList == null) {
return false;
for (String service : whiteList.split(",")) {
if (!service.isEmpty() && serviceAddress.contains(service)) return true;
if (!service.isEmpty() && serviceAddress.contains(service)) {
return true;
return false;
Expand Down

0 comments on commit 4f63b61

Please sign in to comment.