Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Add javax.annotations dependency in bazel build to gax-grpc #1000

Merged
merged 3 commits into from Mar 31, 2020

Conversation

vam-google
Copy link
Contributor

@vam-google vam-google commented Mar 31, 2020

This is to solve java11 incompatibility issue.
Also use transitive dependencies directly from grpc for bazel.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2020
@vam-google vam-google requested a review from yihanzhen Mar 31, 2020
@yihanzhen
Copy link
Contributor

yihanzhen commented Mar 31, 2020

LGTM

@yihanzhen yihanzhen changed the title chore(deps): Add javax.annotations dependency in bazel build to gax-grp chore(deps): Add javax.annotations dependency in bazel build to gax-grpc Mar 31, 2020
@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #1000 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1000   +/-   ##
=========================================
  Coverage     78.66%   78.66%           
  Complexity     1167     1167           
=========================================
  Files           204      204           
  Lines          5152     5152           
  Branches        413      413           
=========================================
  Hits           4053     4053           
  Misses          925      925           
  Partials        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad62e61...a8804dd. Read the comment docs.

@vam-google vam-google merged commit 7300468 into googleapis:master Mar 31, 2020
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants