Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): catch and log exceptions in Watchdog runnable to ensure it never stops running #1036

Merged
merged 4 commits into from Jun 10, 2020

Conversation

justinuang
Copy link
Contributor

@justinuang justinuang commented May 13, 2020

@googlebot googlebot added the cla: yes label May 13, 2020
@codecov
Copy link

@codecov codecov bot commented May 13, 2020

Codecov Report

Merging #1036 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1036      +/-   ##
============================================
- Coverage     78.66%   78.65%   -0.02%     
- Complexity     1169     1170       +1     
============================================
  Files           204      204              
  Lines          5189     5195       +6     
  Branches        417      417              
============================================
+ Hits           4082     4086       +4     
- Misses          933      935       +2     
  Partials        174      174              
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/api/gax/rpc/Watchdog.java 79.67% <66.66%> (-0.67%) 12.00 <2.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63cab8...5882727. Read the comment docs.

Copy link
Collaborator

@igorbernstein2 igorbernstein2 left a comment

lgtm

@justinuang
Copy link
Contributor Author

@justinuang justinuang commented May 13, 2020

Do you mind merging this? Also, Java 7 seems to be failing for unrelated reasons in the build. The other recent open PR has this problem too: #1032

@chingor13 chingor13 changed the title Catch and log exceptions in Watchdog runnable to ensure it never stops running fix(logging): catch and log exceptions in Watchdog runnable to ensure it never stops running Jun 10, 2020
in master, `@InternalApi` was changed to `@BetaApi`
@chingor13 chingor13 merged commit 092007b into googleapis:master Jun 10, 2020
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants