Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

fix: Fix javadoc generation on Java11 #1145

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

vam-google
Copy link
Contributor

Without this fix gradle fails witht he following error for publishing taks (like ./gradlew clean publishMavenJavaPublicationToMavenLocal) when built on Java 11 (it used to work normally on Java 8)

javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/7/docs/api/ are in the unnamed module

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1145   +/-   ##
=========================================
  Coverage     78.65%   78.65%           
  Complexity     1170     1170           
=========================================
  Files           204      204           
  Lines          5195     5195           
  Branches        417      417           
=========================================
  Hits           4086     4086           
  Misses          935      935           
  Partials        174      174           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c832036...f0c83f7. Read the comment docs.

@vam-google vam-google merged commit c7a039e into googleapis:master Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants