fix: Settings objects should not try to read quotaProjectId from credentials#1162
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
============================================
+ Coverage 78.97% 78.99% +0.01%
Complexity 1194 1194
============================================
Files 205 205
Lines 5266 5260 -6
Branches 436 435 -1
============================================
- Hits 4159 4155 -4
+ Misses 935 933 -2
Partials 172 172
Continue to review full report at Codecov.
|
|
The downstream client lib test fails on get gax version ( Line 45 in 2c56c79 |
The change removes the settings objects asking the credentials for the quotaProjectId. The right headers should still be handled correctly for the requests. |
|
I expand this PR to hide header from setting as well see #1162 |
|
@chingor13 I expand this PR to hide header from setting as well see #1162 |
This is causing downstream errors in unit tests because the settings are attempting to load credentials while the settings are being built.
This is a behavioral change. The settings object should not care about what's in the credentials provider when being asked for its configured quotaProjectId. We now will only return an explicitly configured quotaProjectId. ClientContext.create will correctly determine the correct value to use.