Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

fix: fix dependencies.properties resource file creation during deployment #1163

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Aug 5, 2020

This changes the dependencies.properties file to be created into the build/generated-resources directory and includes that directory as part of the sources set.

This should fix the generation version detection.

Verified by running git clean -fdx && ./gradlew publishToMavenLocal. The tests pass during the publish and built jar in the local repo includes the dependencies.properties file.

Fixes #1164

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #1163 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1163   +/-   ##
=========================================
  Coverage     78.97%   78.97%           
  Complexity     1194     1194           
=========================================
  Files           205      205           
  Lines          5266     5266           
  Branches        436      436           
=========================================
  Hits           4159     4159           
  Misses          935      935           
  Partials        172      172           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c56c79...c978c7f. Read the comment docs.

@chingor13 chingor13 changed the title fix: immediately populate the dependencies.properties resource file fix: fix dependencies.properties resource file creation Aug 6, 2020
@chingor13 chingor13 changed the title fix: fix dependencies.properties resource file creation fix: fix dependencies.properties resource file creation during deployment Aug 6, 2020
@chingor13 chingor13 requested review from miraleung and a team August 6, 2020 19:11
Copy link
Contributor

@summer-ji-eng summer-ji-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingor13 chingor13 merged commit 3e7e1f1 into googleapis:master Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.58.0 setting incorrect api-client header
2 participants