Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [gax-java] Fix broken Bazel build #1180

Merged
merged 4 commits into from Sep 14, 2020
Merged

fix: [gax-java] Fix broken Bazel build #1180

merged 4 commits into from Sep 14, 2020

Conversation

miraleung
Copy link
Contributor

@miraleung miraleung commented Sep 9, 2020

No description provided.

@miraleung miraleung requested review from chingor13 and vam-google Sep 9, 2020
@google-cla google-cla bot added the cla: yes label Sep 9, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 9, 2020

Codecov Report

Merging #1180 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1180   +/-   ##
=========================================
  Coverage     78.98%   78.98%           
  Complexity     1194     1194           
=========================================
  Files           205      205           
  Lines          5259     5259           
  Branches        435      435           
=========================================
  Hits           4154     4154           
  Misses          933      933           
  Partials        172      172           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f89877a...f43d592. Read the comment docs.

Copy link
Contributor

@vam-google vam-google left a comment

LGTM, though bazel_skylib version info should probably stay in bazel files directly.

dependencies.properties Outdated Show resolved Hide resolved
@miraleung miraleung merged commit 834c05e into master Sep 14, 2020
9 checks passed
@miraleung miraleung deleted the fix/bazel0 branch Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants