Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [gax-java] Add speedy Bazel builds to Travis #1181

Merged
merged 13 commits into from Sep 15, 2020
Merged

fix: [gax-java] Add speedy Bazel builds to Travis #1181

merged 13 commits into from Sep 15, 2020

Conversation

miraleung
Copy link
Contributor

@miraleung miraleung commented Sep 9, 2020

No description provided.

@miraleung miraleung requested a review from vam-google Sep 9, 2020
@google-cla google-cla bot added the cla: yes label Sep 9, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 9, 2020

Codecov Report

Merging #1181 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1181   +/-   ##
=========================================
  Coverage     78.98%   78.98%           
  Complexity     1194     1194           
=========================================
  Files           205      205           
  Lines          5259     5259           
  Branches        435      435           
=========================================
  Hits           4154     4154           
  Misses          933      933           
  Partials        172      172           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834c05e...ae71fb0. Read the comment docs.

Copy link
Contributor

@vam-google vam-google left a comment

Thanks for doing it! Can we do it as a separate task? Now gradle and bazel go together as a part of the same build, while it would be cleaner if they were two different jobs (this is how ti is done for gapic-generator, for example).

Apart from that, it is simply awesome! Adding bazel build in CI was a long lasting "pending" task that nobody has actually ever done. As you noticed (given the other PR with a fix), the absence of it could cause bazel build for gax to fail even when gradlew one was fine.

@miraleung
Copy link
Contributor Author

@miraleung miraleung commented Sep 14, 2020

No problem. Done, split them into separate tasks.

Base automatically changed from fix/bazel0 to master Sep 14, 2020
@miraleung miraleung requested a review from vam-google Sep 14, 2020
Copy link
Contributor

@vam-google vam-google left a comment

LGTM. Just an optional minor comment, feel free to ignore.

.travis.yml Outdated Show resolved Hide resolved
@miraleung miraleung merged commit 2fb85fe into master Sep 15, 2020
9 checks passed
@miraleung miraleung deleted the fix/bazel1 branch Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants