Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

feat: Allow user-agents to be specified by both internal headers and user headers #1190

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

igorbernstein2
Copy link
Contributor

This is primarily meant to address the googleapis/java-bigtable#404 (review). Where both the hbase adapter and the core client needs to set the UserAgent. To reconcile the conflict this PR takes grpc's approach and concatenates the values. The reason this needs to happen now is that for DirectPath we need to ship clients that send a UserAgent, however Bigtable needs to keep stats to differentiate client usage.

…user headers

This is primarily meant to address the googleapis/java-bigtable#404 (review). Where both the hbase adapter and the core client needs to set the UserAgent. To reconcile the conflict this PR takes grpc's approach and concatenates the values. The reason this needs to happen now is that for DirectPath we need to ship clients that send a UserAgent, however Bigtable needs to keep stats to differentiate client usage.
@igorbernstein2 igorbernstein2 requested a review from a team as a code owner September 23, 2020 16:07
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2020
@igorbernstein2
Copy link
Contributor Author

cc @WeiranFang @kolea2

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #1190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1190   +/-   ##
=========================================
  Coverage     58.91%   58.91%           
  Complexity      115      115           
=========================================
  Files            20       20           
  Lines           589      589           
  Branches         60       60           
=========================================
  Hits            347      347           
  Misses          213      213           
  Partials         29       29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 287cada...429a580. Read the comment docs.

@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 23, 2020
@igorbernstein2
Copy link
Contributor Author

I think kokoro is broken?

@WeiranFang
Copy link
Contributor

Thanks Igor for making this change!

@igorbernstein2 igorbernstein2 merged commit 266329e into googleapis:master Sep 24, 2020
@igorbernstein2 igorbernstein2 deleted the user-agent-merge branch September 24, 2020 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants