This repository was archived by the owner on Sep 26, 2023. It is now read-only.
fix: retain user RPC timeout if set via withTimeout#1324
Merged
Conversation
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1324 +/- ##
=========================================
Coverage 79.65% 79.65%
- Complexity 1248 1249 +1
=========================================
Files 209 209
Lines 5461 5461
Branches 464 464
=========================================
Hits 4350 4350
Misses 928 928
Partials 183 183
Continue to review full report at Codecov.
|
miraleung
approved these changes
Mar 9, 2021
elharo
reviewed
Mar 9, 2021
Contributor
Author
|
@elharo do you want to take another pass or am I OK to merge? |
elharo
reviewed
Mar 10, 2021
elharo
left a comment
elharo
left a comment
Contributor
There was a problem hiding this comment.
You don't need to wait for me. If it's approved, you can merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a Callable has
RetrySettingsand the calculated RPC Timeout for an attempt is less than the constant, RPC timeout provided by the user viaApiCallContext.withTimeout, the attempt settings will win. This is not caller friendly.This PR changes
AttemptCallable, used for Unary RPCs, only attempts to set theApiCallContext.withTimeoutwhen it is not already set by the caller.This was fixed for ServerStreaming RPCs in #1155
Addresses commentary in #1144.