Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add BetaApi tag to setLogicalTimeout #1335

merged 1 commit into from Mar 25, 2021


Copy link

@noahdietz noahdietz commented Mar 25, 2021

I forgot to add the @BetaApi annotation to the new RetrySettings.Builder.setLogicalTimeout helper in #1334 .

@noahdietz noahdietz requested review from as code owners Mar 25, 2021
@google-cla google-cla bot added the cla: yes label Mar 25, 2021
Copy link

@codecov codecov bot commented Mar 25, 2021

Codecov Report

Merging #1335 (5891c5d) into master (97d3214) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1335   +/-   ##
  Coverage     80.53%   80.53%           
  Complexity     1331     1331           
  Files           210      210           
  Lines          5686     5686           
  Branches        519      519           
  Hits           4579     4579           
  Misses          895      895           
  Partials        212      212           
Impacted Files Coverage Δ Complexity Δ
...ava/com/google/api/gax/retrying/ 55.76% <ø> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97d3214...5891c5d. Read the comment docs.

@noahdietz noahdietz merged commit fc7169d into googleapis:master Mar 25, 2021
9 checks passed
@noahdietz noahdietz deleted the beta-set-logical branch Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants