fix: fix watchdog NPE red herring #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1344 +/- ##
=========================================
Coverage 81.42% 81.43%
Complexity 1346 1346
=========================================
Files 211 211
Lines 5728 5730 +2
Branches 526 527 +1
=========================================
+ Hits 4664 4666 +2
Misses 851 851
Partials 213 213
Continue to review full report at Codecov.
|
elharo
approved these changes
Apr 8, 2021
| callable1.call("request", observer); | ||
| // This should cancel callable1 | ||
| watchdog.run(); | ||
| assertThat(callable1.popLastCall().getController().isCancelled()).isTrue(); |
There was a problem hiding this comment.
use of truth here feels gratuitous since assertTrue is simple and obvious
igorbernstein2
approved these changes
Apr 9, 2021
igorbernstein2
added
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If CPU is overloaded, it's possible that the stream doesn't get started after idle timeout. In this case, innerController is not set and innerController.cancel() will throw NPE. The NPE is caught in
run()and watchdog will still behave correctly, but the exception could be confusing. Adding a check to skip cancelIfStale to avoid the red herring.