Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix dynamic flow control setting checks #1347

Merged
merged 2 commits into from Apr 21, 2021

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Apr 19, 2021

If LimitedExceededBehavior is Ignore, skip checking if all the elements or bytes limit are set.

@mutianf mutianf requested review from as code owners Apr 19, 2021
@google-cla google-cla bot added the cla: yes label Apr 19, 2021
@codecov
Copy link

@codecov codecov bot commented Apr 19, 2021

Codecov Report

Merging #1347 (18f6024) into master (06dbf12) will decrease coverage by 0.03%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1347      +/-   ##
============================================
- Coverage     81.46%   81.43%   -0.04%     
+ Complexity     1347     1346       -1     
============================================
  Files           211      211              
  Lines          5730     5730              
  Branches        527      525       -2     
============================================
- Hits           4668     4666       -2     
- Misses          850      851       +1     
- Partials        212      213       +1     
Impacted Files Coverage Δ Complexity Δ
...e/api/gax/batching/DynamicFlowControlSettings.java 83.72% <70.00%> (ø) 2.00 <0.00> (ø)
.../java/com/google/api/gax/batching/BatcherImpl.java 94.94% <0.00%> (-1.13%) 22.00% <0.00%> (-1.00%)
.../google/api/gax/batching/NonBlockingSemaphore.java 81.57% <0.00%> (ø) 12.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06dbf12...18f6024. Read the comment docs.

Copy link
Contributor

@vam-google vam-google left a comment

LGTM, but please address Igor's comments first.

@igorbernstein2 igorbernstein2 merged commit 69458b4 into googleapis:master Apr 21, 2021
7 of 9 checks passed
@mutianf mutianf deleted the fix_setting branch Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants