Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove default value handling #1353

Merged
merged 2 commits into from Apr 30, 2021
Merged

Conversation

vam-google
Copy link
Contributor

@vam-google vam-google commented Apr 28, 2021

This is done in favor of explicit optional field handling in the generator.

This is done in favor of explicit `optional` field handling in the generator.
@vam-google vam-google requested review from as code owners Apr 28, 2021
@google-cla google-cla bot added the cla: yes label Apr 28, 2021
@vam-google vam-google requested a review from miraleung Apr 28, 2021
@codecov
Copy link

@codecov codecov bot commented Apr 28, 2021

Codecov Report

Merging #1353 (a61c6f3) into master (52e39f8) will decrease coverage by 0.06%.
The diff coverage is n/a.

Current head a61c6f3 differs from pull request most recent head a197843. Consider uploading reports for the commit a197843 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1353      +/-   ##
============================================
- Coverage     81.46%   81.40%   -0.07%     
+ Complexity     1347     1340       -7     
============================================
  Files           211      211              
  Lines          5730     5721       -9     
  Branches        525      523       -2     
============================================
- Hits           4668     4657      -11     
- Misses          850      851       +1     
- Partials        212      213       +1     
Impacted Files Coverage Δ Complexity Δ
...m/google/api/gax/httpjson/ProtoRestSerializer.java 90.00% <ø> (-3.11%) 8.00 <0.00> (-6.00)
.../java/com/google/api/gax/batching/BatcherImpl.java 94.94% <0.00%> (-1.13%) 22.00% <0.00%> (-1.00%)
.../google/api/gax/batching/NonBlockingSemaphore.java 81.57% <0.00%> (ø) 12.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a53ac...a197843. Read the comment docs.

@vam-google vam-google merged commit ed0fc79 into googleapis:master Apr 30, 2021
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants