Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promote to 2.0.0 #1444

Merged
merged 3 commits into from Jul 30, 2021
Merged

feat: promote to 2.0.0 #1444

merged 3 commits into from Jul 30, 2021

Conversation

Neenu1995
Copy link
Contributor

@Neenu1995 Neenu1995 commented Jul 30, 2021

Release-As: 2.0.0

Release-As: 2.0.0
@google-cla google-cla bot added the cla: yes label Jul 30, 2021
@Neenu1995 Neenu1995 requested review from as code owners Jul 30, 2021
@Neenu1995 Neenu1995 added the automerge label Jul 30, 2021
Copy link
Contributor

@vam-google vam-google left a comment

LGTM

@@ -2,9 +2,9 @@ load("//:gax_java.bzl", "google_java_format", "google_java_format_verification",

_JAVA_COPTS = [
"-source",
"1.7",
"1.8",
Copy link
Contributor

@vam-google vam-google Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be just 8, but good enough (1.8 and 8 are synnonyms, but there is no 1.9 and above, just 9, 10, 11...)

@Neenu1995 Neenu1995 merged commit 776b1aa into master Jul 30, 2021
7 checks passed
@Neenu1995 Neenu1995 deleted the java8-2.0 branch Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants