Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

feat: promote to 2.0.0 #1444

Merged
merged 3 commits into from
Jul 30, 2021
Merged

feat: promote to 2.0.0 #1444

merged 3 commits into from
Jul 30, 2021

Conversation

Neenu1995
Copy link
Contributor

Release-As: 2.0.0

Release-As: 2.0.0
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2021
@Neenu1995 Neenu1995 requested review from a team as code owners July 30, 2021 01:55
@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 30, 2021
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,9 +2,9 @@ load("//:gax_java.bzl", "google_java_format", "google_java_format_verification",

_JAVA_COPTS = [
"-source",
"1.7",
"1.8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be just 8, but good enough (1.8 and 8 are synnonyms, but there is no 1.9 and above, just 9, 10, 11...)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants