Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix closeAsync #1446

Merged
merged 1 commit into from Aug 5, 2021
Merged

fix: fix closeAsync #1446

merged 1 commit into from Aug 5, 2021

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Aug 5, 2021

If closeAsync is called before sending out all the elements, it's possible that scheduled PushCurrentBatchRunnable is still sending the elements when scheduledFuture.cancel is called, and the thread shouldn't be interrupted.

@mutianf mutianf requested review from as code owners Aug 5, 2021
@google-cla google-cla bot added the cla: yes label Aug 5, 2021
@mutianf mutianf changed the title fix: make closeAsync don't interrupt running thread fix: fix closeAsync Aug 5, 2021
Copy link
Collaborator

@igorbernstein2 igorbernstein2 left a comment

Lgtm

@igorbernstein2 igorbernstein2 merged commit 7c6c298 into googleapis:master Aug 5, 2021
6 checks passed
@mutianf mutianf deleted the deflake branch Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants