Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

fix: fix closeAsync #1446

Merged
merged 1 commit into from
Aug 5, 2021
Merged

fix: fix closeAsync #1446

merged 1 commit into from
Aug 5, 2021

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Aug 5, 2021

If closeAsync is called before sending out all the elements, it's possible that scheduled PushCurrentBatchRunnable is still sending the elements when scheduledFuture.cancel is called, and the thread shouldn't be interrupted.

@mutianf mutianf requested review from a team as code owners August 5, 2021 16:29
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2021
@mutianf mutianf changed the title fix: make closeAsync don't interrupt running thread fix: fix closeAsync Aug 5, 2021
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants