Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

fix: Fix com.google.rpc.Code to StatusCode.Code conversion logic #1508

Merged
merged 4 commits into from
Oct 13, 2021

Conversation

vam-google
Copy link
Contributor

Also add tests for HTTP status code conversion (according to the current implementation, which may change in the future).

Also add tests for HTTP status code conversion (according to the current implementation, which may change in the future).
@vam-google vam-google requested review from a team as code owners October 11, 2021 21:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2021
@vam-google
Copy link
Contributor Author

@viacheslav-rostovtsev FYI

*/
package com.google.api.gax.httpjson;

import static org.junit.Assert.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expand the imports?

StatusCode.Code.DEADLINE_EXCEEDED,
HttpJsonStatusCode.httpStatusToStatusCode(504, "anything"));

try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: recommending assertThrows. I found one example in this repo, but you will want a lambda:

assertThrows(IllegalStateException.class, () -> HttpJsonStatusCode.httpStatusToStatusCode(411, "anything"));

@vam-google vam-google merged commit 61b1617 into googleapis:main Oct 13, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 13, 2021
🤖 I have created a release \*beep\* \*boop\*
---
### [2.5.3](https://www.github.com/googleapis/gax-java/compare/v2.5.2...v2.5.3) (2021-10-13)


### Bug Fixes

* Fix `com.google.rpc.Code` to `StatusCode.Code` conversion  logic ([#1508](https://www.github.com/googleapis/gax-java/issues/1508)) ([61b1617](https://www.github.com/googleapis/gax-java/commit/61b161799faf292be1394111381f8a35e757b85a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants