fix: Fix com.google.rpc.Code to StatusCode.Code conversion logic
#1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add tests for HTTP status code conversion (according to the current implementation, which may change in the future).
google-cla
bot
added
the
cla: yes
chanseokoh
approved these changes
Oct 11, 2021
| */ | ||
| package com.google.api.gax.httpjson; | ||
|
|
||
| import static org.junit.Assert.*; |
| StatusCode.Code.DEADLINE_EXCEEDED, | ||
| HttpJsonStatusCode.httpStatusToStatusCode(504, "anything")); | ||
|
|
||
| try { |
There was a problem hiding this comment.
Nit: recommending assertThrows. I found one example in this repo, but you will want a lambda:
assertThrows(IllegalStateException.class, () -> HttpJsonStatusCode.httpStatusToStatusCode(411, "anything"));
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Oct 13, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.5.3](https://www.github.com/googleapis/gax-java/compare/v2.5.2...v2.5.3) (2021-10-13) ### Bug Fixes * Fix `com.google.rpc.Code` to `StatusCode.Code` conversion logic ([#1508](https://www.github.com/googleapis/gax-java/issues/1508)) ([61b1617](https://www.github.com/googleapis/gax-java/commit/61b161799faf292be1394111381f8a35e757b85a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Also add tests for HTTP status code conversion (according to the current implementation, which may change in the future).