Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update com_google_protobuf to 3.18.1 #1519

Merged
merged 9 commits into from Oct 15, 2021
Merged

Conversation

Neenu1995
Copy link
Contributor

@Neenu1995 Neenu1995 commented Oct 14, 2021

deps: update guava to v31
deps: update grpc to 1.41.0
deps: update auto-value to 1.8.2
deps: update api-common to 2.0.5
deps: update google-http-client to 1.40.1
feat: remove deprecated Generated annotation
fix: Fix com.google.rpc.Code to StatusCode.Code conversion logic

@Neenu1995 Neenu1995 requested review from as code owners Oct 14, 2021
@google-cla google-cla bot added the cla: yes label Oct 14, 2021
@Neenu1995 Neenu1995 changed the title deps: update com_google_protobuf deps: update com_google_protobuf to 3.18.1 Oct 14, 2021
@chanseokoh
Copy link
Contributor

@chanseokoh chanseokoh commented Oct 14, 2021

Looks like this causes compilation failure?

@Neenu1995
Copy link
Contributor Author

@Neenu1995 Neenu1995 commented Oct 14, 2021

Yes.. we are looking into this.

@chanseokoh
Copy link
Contributor

@chanseokoh chanseokoh commented Oct 14, 2021

Question: will these annotations come back when these classes are re-generated?

@Generated("by gapic-generator-java")

@Neenu1995
Copy link
Contributor Author

@Neenu1995 Neenu1995 commented Oct 14, 2021

I don't think code gets automatically re-generated in this repo anymore.

@vam-google
Copy link
Contributor

@vam-google vam-google commented Oct 14, 2021

@chanseokoh @Neenu1995 The @Generated annotation is not necessary and more of a historical artifact. The clases marked by it were indeed generated by the generator originally, but only to provide the original basic version of classes, which are not expected to be ergenerated in the future but maintained/updated by hand. That is why removing @Generated the right thing to do regardless of the compilation failures.

Copy link
Contributor

@vam-google vam-google left a comment

LGTM

@Neenu1995 Neenu1995 added the do not merge label Oct 14, 2021
@Neenu1995
Copy link
Contributor Author

@Neenu1995 Neenu1995 commented Oct 14, 2021

Merge after the release pipeline has been fixed.

@Neenu1995 Neenu1995 changed the title deps: update com_google_protobuf to 3.18.1 feat: update com_google_protobuf to 3.18.1 Oct 15, 2021
@Neenu1995 Neenu1995 changed the title feat: update com_google_protobuf to 3.18.1 deps: update com_google_protobuf to 3.18.1 Oct 15, 2021
@meltsufin meltsufin added automerge and removed do not merge labels Oct 15, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2d76bff into main Oct 15, 2021
5 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the dependency-update branch Oct 15, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Oct 15, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 15, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [2.6.0](https://www.github.com/googleapis/gax-java/compare/v2.5.3...v2.6.0) (2021-10-15)


### Features

* remove deprecated Generated annotation ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))


### Bug Fixes

* Fix com.google.rpc.Code to StatusCode.Code conversion logic ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))


### Dependencies

* update api-common to 2.0.5 ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))
* update auto-value to 1.8.2 ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))
* update com_google_protobuf to 3.18.1 ([#1519](https://www.github.com/googleapis/gax-java/issues/1519)) ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))
* update google-http-client to 1.40.1 ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))
* update grpc to 1.41.0 ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))
* update guava to v31 ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants