Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass error message when creating ApiException #1556

merged 1 commit into from Nov 15, 2021


Copy link

@chanseokoh chanseokoh commented Nov 12, 2021

Fixes #1557.

@chanseokoh chanseokoh requested review from meltsufin and vam-google Nov 12, 2021
@chanseokoh chanseokoh requested review from as code owners Nov 12, 2021
@google-cla google-cla bot added the cla: yes label Nov 12, 2021
Copy link

@meltsufin meltsufin commented Nov 15, 2021

Is there an issue associated with this?

return new UnknownException(cause, statusCode, retryable);
return new UnknownException(message, cause, statusCode, retryable);
Copy link

@meltsufin meltsufin Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor Author

@chanseokoh chanseokoh commented Nov 15, 2021

Is there an issue associated with this?

No. Just filed #1557.

@chanseokoh chanseokoh merged commit 918ae41 into main Nov 15, 2021
6 checks passed
@chanseokoh chanseokoh deleted the fix-ApiExceptionFactory branch Nov 15, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Dec 2, 2021
🤖 I have created a release \*beep\* \*boop\*
### [2.7.1]( (2021-12-02)

### Bug Fixes

* fix gRPC code conversion ([#1555]( ([09b99d5](
* pass error message when creating ApiException ([#1556]( ([918ae41](
* revert generics syntax change in MockHttpService test utility ([#1574]( ([b629488](
* update exception mapping on HTTP error responses ([#1570]( ([8a170d1](

### Dependencies

* update grpc to 1.42.1 ([#1559]( ([92b7632](
* upgrade protobuf to 3.19.1 ([#1571]( ([7b354e7](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes
None yet

Successfully merging this pull request may close these issues.

2 participants