Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert generics syntax change in MockHttpService test utility #1574

Merged
merged 4 commits into from Dec 1, 2021

Conversation

chanseokoh
Copy link
Contributor

@chanseokoh chanseokoh commented Dec 1, 2021

In the cleanup PR #1554, I added the generics syntax for parameterized types in some cases. When I was doing it, I was careful to not change anything publicly visible (e.g., only change files user src/test/..., local method code, private method signature, etc.).

However, it turns out MockHttpService undersrc/test/... is published to Maven Central (as a test utility as testlib) and being used in units test in library repos.

@chanseokoh chanseokoh requested review from meltsufin and vam-google Dec 1, 2021
@chanseokoh chanseokoh requested review from as code owners Dec 1, 2021
@google-cla google-cla bot added the cla: yes label Dec 1, 2021
@chanseokoh chanseokoh changed the title Revert method sig on test class Revert generics syntax change in MockHttpServer test utility Dec 1, 2021
@chanseokoh chanseokoh changed the title Revert generics syntax change in MockHttpServer test utility Revert generics syntax change in MockHttpService test utility Dec 1, 2021
@chanseokoh chanseokoh changed the title Revert generics syntax change in MockHttpService test utility fix: revert generics syntax change in MockHttpService test utility Dec 1, 2021
@chanseokoh chanseokoh merged commit b629488 into main Dec 1, 2021
6 checks passed
@chanseokoh chanseokoh deleted the revert-method-sig-on-test-class branch Dec 1, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Dec 2, 2021
🤖 I have created a release \*beep\* \*boop\*
---
### [2.7.1](https://www.github.com/googleapis/gax-java/compare/v2.7.0...v2.7.1) (2021-12-02)


### Bug Fixes

* fix gRPC code conversion ([#1555](https://www.github.com/googleapis/gax-java/issues/1555)) ([09b99d5](https://www.github.com/googleapis/gax-java/commit/09b99d591497b44c3c25b1a54abb0f1cb69d7376))
* pass error message when creating ApiException ([#1556](https://www.github.com/googleapis/gax-java/issues/1556)) ([918ae41](https://www.github.com/googleapis/gax-java/commit/918ae419f84ad5721638ca10eca992333e9f7c3d))
* revert generics syntax change in MockHttpService test utility ([#1574](https://www.github.com/googleapis/gax-java/issues/1574)) ([b629488](https://www.github.com/googleapis/gax-java/commit/b629488ffc7d68158158d9197695158f97229c7b))
* update exception mapping on HTTP error responses ([#1570](https://www.github.com/googleapis/gax-java/issues/1570)) ([8a170d1](https://www.github.com/googleapis/gax-java/commit/8a170d19b42e9b13d4c69dcfbe531d4d4ca69c90))


### Dependencies

* update grpc to 1.42.1 ([#1559](https://www.github.com/googleapis/gax-java/issues/1559)) ([92b7632](https://www.github.com/googleapis/gax-java/commit/92b76325d54604c98c798c489b3a963fdf21a75c))
* upgrade protobuf to 3.19.1 ([#1571](https://www.github.com/googleapis/gax-java/issues/1571)) ([7b354e7](https://www.github.com/googleapis/gax-java/commit/7b354e73b8ce49008bed51076afb255ca5dc68e4))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants