Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update DirectPath xds scheme #1585

Merged
merged 1 commit into from Jan 5, 2022
Merged

Conversation

mohanli-ml
Copy link
Contributor

@mohanli-ml mohanli-ml commented Dec 23, 2021

Follow grpc/grpc-java#8744 to update the xds scheme for DirectPath.

@mohanli-ml mohanli-ml requested review from as code owners Dec 23, 2021
@@ -339,7 +339,8 @@ private ManagedChannel createSingleChannel() throws IOException, GeneralSecurity
isDirectPathXdsEnabled = Boolean.parseBoolean(envProvider.getenv(DIRECT_PATH_ENV_ENABLE_XDS));
if (isDirectPathXdsEnabled) {
// google-c2p resolver target must not have a port number
Copy link
Member

@meltsufin meltsufin Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the comment be updated too?

Copy link
Contributor Author

@mohanli-ml mohanli-ml Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking. I think the comment should be fine as we will eventually use google-c2p once google-c2p-experimental is stable.

@meltsufin meltsufin merged commit 7915f85 into googleapis:main Jan 5, 2022
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants