Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

feat: update DirectPath xds scheme #1585

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

mohanli-ml
Copy link
Contributor

Follow grpc/grpc-java#8744 to update the xds scheme for DirectPath.

@mohanli-ml mohanli-ml requested review from a team as code owners December 23, 2021 19:41
@@ -339,7 +339,8 @@ private ManagedChannel createSingleChannel() throws IOException, GeneralSecurity
isDirectPathXdsEnabled = Boolean.parseBoolean(envProvider.getenv(DIRECT_PATH_ENV_ENABLE_XDS));
if (isDirectPathXdsEnabled) {
// google-c2p resolver target must not have a port number
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the comment be updated too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking. I think the comment should be fine as we will eventually use google-c2p once google-c2p-experimental is stable.

@meltsufin meltsufin merged commit 7915f85 into googleapis:main Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants