New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasetool compatibility and instructions #598

Merged
merged 6 commits into from Oct 11, 2018

Conversation

Projects
None yet
4 participants
@chingor13
Contributor

chingor13 commented Oct 8, 2018

Depends on googleapis/releasetool#74

  • Move the individual version.txt versions into a single version.txt file at the root
  • Tag all locations in the repo that need versions to be updated at each release
  • Delete the templates/ directory
  • Delete the updateSamples and updateReadme tasks in build.gradle
  • Update the release instructions

Fixes #595

@chingor13 chingor13 requested a review from garrettjonesgoogle Oct 8, 2018

@googlebot googlebot added the cla: yes label Oct 8, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Oct 8, 2018

Codecov Report

Merging #598 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #598   +/-   ##
=========================================
  Coverage     75.02%   75.02%           
  Complexity      934      934           
=========================================
  Files           176      176           
  Lines          4076     4076           
  Branches        323      323           
=========================================
  Hits           3058     3058           
  Misses          865      865           
  Partials        153      153

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b842b23...0432d60. Read the comment docs.

@garrettjonesgoogle

This comment has been minimized.

Member

garrettjonesgoogle commented Oct 8, 2018

Fixes #595

A couple missing things from the issue:

  • Delete the templates/ directory
  • Delete the updateSamples and updateReadme tasks in build.gradle

@chingor13 chingor13 changed the title from WIP: releasetool compatibility and instructions to Releasetool compatibility and instructions Oct 10, 2018

@chingor13

This comment has been minimized.

Contributor

chingor13 commented Oct 11, 2018

We can't fully remove the templates/ directory as the createApiDocsRedirect gradle task cannot be replicated by releasetool

@garrettjonesgoogle

Oh, right! That makes sense.

@chingor13 chingor13 merged commit eca14d4 into googleapis:master Oct 11, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Raibaz added a commit to Raibaz/gax-java that referenced this pull request Oct 25, 2018

Releasetool compatibility and instructions (googleapis#598)
* Use explicit versions in build.gradle and add replace tags

* Add benchmark artifact version

* Update RELEASING.md with releasetool usage

* Remove version.txt files. They are now managed by the versions.txt file

* Fix starting versions of benchmark and gax-httpjson artifacts

* README.md and samples/pom.xml can use releasetool's replacement feature

Raibaz added a commit to Raibaz/gax-java that referenced this pull request Oct 25, 2018

Releasetool compatibility and instructions (googleapis#598)
* Use explicit versions in build.gradle and add replace tags

* Add benchmark artifact version

* Update RELEASING.md with releasetool usage

* Remove version.txt files. They are now managed by the versions.txt file

* Fix starting versions of benchmark and gax-httpjson artifacts

* README.md and samples/pom.xml can use releasetool's replacement feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment