Create a executorService with a separate pool of threads for channelpool #836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Refreshing ChannelPool shares the executorService with gRPC. This could lead to undesirable behaviour. If it takes a while (a few seconds) to refresh a channel and many channels are being refreshed at the same time, it could occupy all the threads in the executorService and starve gRPC from using them.
Proposed is to create a separate executorService with its own pools of threads. It shouldn't need many threads to refresh the channels.