Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: Replace native maven_jar rule with jvm_maven_import_external #837

Merged
merged 1 commit into from Dec 24, 2019

Conversation

vam-google
Copy link
Contributor

@vam-google vam-google commented Dec 23, 2019

The native maven_jar was removed in bazel 2.x, this fix is needed to fix build for bazel 2.0.
The build remains backward compatible with bazel 1.x.

The native maven_jar was removed in bazel 2.x, this fix is needed to fix build for bazel 2.0.
The build remains backward compatible with bazel 1.x.
@googlebot googlebot added the cla: yes label Dec 23, 2019
@codecov
Copy link

@codecov codecov bot commented Dec 23, 2019

Codecov Report

Merging #837 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #837   +/-   ##
=========================================
  Coverage     78.72%   78.72%           
  Complexity     1146     1146           
=========================================
  Files           202      202           
  Lines          5099     5099           
  Branches        405      405           
=========================================
  Hits           4014     4014           
  Misses          912      912           
  Partials        173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7aafc...bfca9ee. Read the comment docs.

@vam-google vam-google merged commit 9f83322 into googleapis:master Dec 24, 2019
5 checks passed
@kolea2 kolea2 mentioned this pull request Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants