test: cleaning up deprecated usages #858

rahulKQL · 2020-01-23T12:56:49Z

Fixes #857

removed deprecated ExpectedException.none() usage across unit test cases.

codecov · 2020-01-23T12:59:49Z

Codecov Report

Merging #858 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #858   +/-   ##
=========================================
  Coverage     78.66%   78.67%           
  Complexity     1167     1167           
=========================================
  Files           204      204           
  Lines          5152     5154    +2     
  Branches        413      413           
=========================================
+ Hits           4053     4055    +2     
  Misses          925      925           
  Partials        174      174

Impacted Files	Coverage Δ	Complexity Δ
...java/com/google/api/gax/rpc/UnaryCallSettings.java	`100.00% <0.00%> (ø)`	`5.00% <0.00%> (ø%)`
...oogle/api/gax/rpc/ServerStreamingCallSettings.java	`67.85% <0.00%> (+0.58%)`	`6.00% <0.00%> (ø%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a676891...a65b19f. Read the comment docs.

gax-grpc/src/test/java/com/google/api/gax/grpc/GrpcCallContextTest.java

elharo

You can catch more specific types than java.lang.Exception for more precise tests here.

gax-grpc/src/test/java/com/google/api/gax/grpc/ProtoOperationTransformersTest.java

gax-httpjson/src/test/java/com/google/api/gax/httpjson/ApiMessageOperationTransformersTest.java

gax-httpjson/src/test/java/com/google/api/gax/httpjson/RetryingTest.java

gax/src/test/java/com/google/api/gax/batching/ThresholdBatcherTest.java

elharo

noit sure why this failed:

FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring root project 'gax-java'.

Could not resolve all artifacts for configuration ':classpath'.
Could not resolve net.ltgt.gradle:gradle-apt-plugin:0.10.
Required by:
project :
> Could not resolve net.ltgt.gradle:gradle-apt-plugin:0.10.
> Could not get resource 'https://plugins.gradle.org/m2/net/ltgt/gradle/gradle-apt-plugin/0.10/gradle-apt-plugin-0.10.pom'.
> Could not GET 'https://plugins.gradle.org/m2/net/ltgt/gradle/gradle-apt-plugin/0.10/gradle-apt-plugin-0.10.pom'.
> sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed
Could not resolve gradle.plugin.com.dorongold.plugins:task-tree:1.3.1.
Required by:
project :
> Could not resolve gradle.plugin.com.dorongold.plugins:task-tree:1.3.1.
> Could not get resource 'https://plugins.gradle.org/m2/gradle/plugin/com/dorongold/plugins/task-tree/1.3.1/task-tree-1.3.1.pom'.
> Could not GET 'https://plugins.gradle.org/m2/gradle/plugin/com/dorongold/plugins/task-tree/1.3.1/task-tree-1.3.1.pom'.
> sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed
Could not resolve gradle.plugin.com.github.sherter.google-java-format:google-java-format-gradle-plugin:0.6.
Required by:
project :
> Could not resolve gradle.plugin.com.github.sherter.google-java-format:google-java-format-gradle-plugin:0.6.
> Could not get resource 'https://plugins.gradle.org/m2/gradle/plugin/com/github/sherter/google-java-format/google-java-format-gradle-plugin/0.6/google-java-format-gradle-plugin-0.6.pom'.
> Could not GET 'https://plugins.gradle.org/m2/gradle/plugin/com/github/sherter/google-java-format/google-java-format-gradle-plugin/0.6/google-java-format-gradle-plugin-0.6.pom'.
> sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed

elharo · 2020-02-24T21:26:00Z

gax/src/test/java/com/google/api/gax/rpc/RetryingTest.java

+    try {
+      callable.call(1);
+      Assert.fail("Callable should have thrown an exception");
+    } catch (Exception expected) {


RuntimeException or something more specific. Other exceptions can still cause the test to fail.

removed deprecated `ExpectedException.none()` usage across unit test cases. chore: address feedback comments

rahulKQL · 2020-04-08T19:06:16Z

@elharo I am really sorry for this stale PR. Until last week it's Java 7 presubmit job was failing, finally its green now.

Would you please have another look, I addressed your previous feedback comments.

elharo · 2020-04-08T19:41:52Z

gax-grpc/src/test/java/com/google/api/gax/grpc/ProtoOperationTransformersTest.java

@@ -29,27 +29,26 @@
 */
 package com.google.api.gax.grpc;

+import static com.google.common.truth.Truth.assertThat;


Don't static import this since there are at least three different assertThat's this could be

Isn't this the recommended way to use Truth?
https://truth.dev/#2-add-static-imports-for-truths-entry-points

I actively disagree with that recommendation. I like to know where my methods come from. In this case I was about to send you a completely wrong review because I assumed it was a different assertThat() method than it actually was. As I said, there are at least three in common use. Removing ambiguity is important for readability.

@elharo Thanks for the review!!

I have removed static Truth.assertThat import introduced in this PR, Please have another look.

elharo · 2020-04-08T19:41:52Z

gax-httpjson/src/test/java/com/google/api/gax/httpjson/RetryingTest.java

@@ -29,6 +29,8 @@
 */
 package com.google.api.gax.httpjson;

+import static com.google.common.truth.Truth.assertThat;


Don't static import this since there are at least three different assertThat's this could be

elharo · 2020-04-08T19:41:52Z

gax/src/test/java/com/google/api/gax/rpc/BatchedRequestIssuerTest.java

@@ -29,28 +29,25 @@
 */
 package com.google.api.gax.rpc;

-import com.google.common.truth.Truth;
+import static com.google.common.truth.Truth.assertThat;


Don't static import this since there are at least three different assertThat's this could be

elharo · 2020-04-08T19:41:52Z

gax/src/test/java/com/google/api/gax/rpc/RetryingTest.java

@@ -29,6 +29,8 @@
 */
 package com.google.api.gax.rpc;

+import static com.google.common.truth.Truth.assertThat;


Don't static import this since there are at least three different assertThat's this could be

vam-google

LGTM

googlebot added the cla: yes label Jan 23, 2020

rahulKQL requested review from igorbernstein2 and kolea2 Jan 23, 2020

elharo suggested changes Jan 31, 2020

View changes

gax-grpc/src/test/java/com/google/api/gax/grpc/GrpcCallContextTest.java Outdated Show resolved Hide resolved

rahulKQL requested a review from elharo Feb 3, 2020

elharo reviewed Feb 3, 2020

View changes

elharo approved these changes Feb 3, 2020

View changes

elharo suggested changes Feb 3, 2020

View changes

rahulKQL added the kokoro:force-run label Feb 4, 2020

kokoro-team removed the kokoro:force-run label Feb 4, 2020

elharo reviewed Feb 24, 2020

View changes

rahulKQL force-pushed the test_deprecation branch from 7694668 to 9489a08 Compare Feb 27, 2020

rahulKQL added kokoro:run kokoro:force-run and removed kokoro:run labels Feb 27, 2020

kokoro-team removed the kokoro:force-run label Feb 27, 2020

rahulKQL added the kokoro:force-run label Feb 28, 2020

kokoro-team removed the kokoro:force-run label Feb 28, 2020

test: cleaning up deprecated usages

bb4a7b7

removed deprecated `ExpectedException.none()` usage across unit test cases. chore: address feedback comments

rahulKQL force-pushed the test_deprecation branch from 9489a08 to bb4a7b7 Compare Mar 31, 2020

igorbernstein2 requested review from vam-google and removed request for igorbernstein2 Apr 2, 2020

rahulKQL added the kokoro:force-run label Apr 8, 2020

kokoro-team removed the kokoro:force-run label Apr 8, 2020

rahulKQL requested a review from elharo Apr 8, 2020

elharo reviewed Apr 8, 2020

View changes

chore: removed Truth.assertThat as static import

a65b19f

rahulKQL requested a review from elharo Apr 9, 2020

elharo approved these changes Apr 9, 2020

View changes

vam-google approved these changes Apr 10, 2020

View changes

rahulKQL merged commit b988b95 into googleapis:master Apr 10, 2020
8 checks passed

chingor13 mentioned this pull request Jun 10, 2020

Release gax-java v1.57.0 #1127

Merged

test: cleaning up deprecated usages #858

test: cleaning up deprecated usages #858

rahulKQL commented Jan 23, 2020

codecov bot commented Jan 23, 2020 •

edited

elharo left a comment

elharo left a comment

elharo Feb 24, 2020

rahulKQL commented Apr 8, 2020

elharo Apr 8, 2020

igorbernstein2 Apr 8, 2020

elharo Apr 8, 2020

rahulKQL Apr 9, 2020

elharo Apr 8, 2020

elharo Apr 8, 2020

elharo Apr 8, 2020

vam-google left a comment

test: cleaning up deprecated usages #858

test: cleaning up deprecated usages #858

Conversation

rahulKQL commented Jan 23, 2020

codecov bot commented Jan 23, 2020 • edited

Codecov Report

elharo left a comment

elharo left a comment

Choose a reason for hiding this comment

rahulKQL commented Apr 8, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vam-google left a comment

codecov bot commented Jan 23, 2020 •

edited