Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: update protobuf and gRPC #882

Merged
merged 5 commits into from Feb 27, 2020
Merged

dep: update protobuf and gRPC #882

merged 5 commits into from Feb 27, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 24, 2020

@elharo elharo requested a review from chingor13 Feb 24, 2020
@googlebot googlebot added the cla: yes label Feb 24, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 24, 2020

Codecov Report

Merging #882 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #882   +/-   ##
=========================================
  Coverage     78.63%   78.63%           
  Complexity     1163     1163           
=========================================
  Files           203      203           
  Lines          5143     5143           
  Branches        413      413           
=========================================
  Hits           4044     4044           
  Misses          925      925           
  Partials        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78617fb...93192d8. Read the comment docs.

@elharo
Copy link
Contributor Author

@elharo elharo commented Feb 24, 2020

Looks like a plugin is not Java 11 compatible:

java.lang.NoClassDefFoundError: javax/lang/model/element/Modifier
at com.google.googlejavaformat.java.ModifierOrderer.getModifier(ModifierOrderer.java:45)
at com.google.googlejavaformat.java.ModifierOrderer.asModifier(ModifierOrderer.java:153)
at com.google.googlejavaformat.java.ModifierOrderer.reorderModifiers(ModifierOrderer.java:100)
at com.google.googlejavaformat.java.Formatter.getFormatReplacements(Formatter.java:180)
at com.google.googlejavaformat.java.Formatter.formatSource(Formatter.java:163)
at com.google.googlejavaformat.java.Formatter.formatSource(Formatter.java:149)
at com.google.googlejavaformat.java.Formatter$formatSource.call(Unknown Source)
at com.github.sherter.googlejavaformatgradleplugin.format.OneDotOneFactory$_create_closure1.doCall(OneDotOneFactory.groovy:31)
at jdk.internal.reflect.GeneratedMethodAccessor180.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1022)
at groovy.lang.Closure.call(Closure.java:414)
at org.codehaus.groovy.runtime.ConvertedClosure.invokeCustom(ConvertedClosure.java:54)
at org.codehaus.groovy.runtime.ConversionHandler.invoke(ConversionHandler.java:124)
at com.sun.proxy.$Proxy81.format(Unknown Source)
at com.github.sherter.googlejavaformatgradleplugin.VerifyFileCallable.call(VerifyFileCallable.java:29)
at com.github.sherter.googlejavaformatgradleplugin.VerifyFileCallable.call(VerifyFileCallable.java:11)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':verifyGoogleJavaFormat'.

Problems: I/O errors

@rahulKQL rahulKQL added the kokoro:force-run label Feb 27, 2020
@kokoro-team kokoro-team removed the kokoro:force-run label Feb 27, 2020
@elharo elharo added kokoro:force-run kokoro:run labels Feb 27, 2020
@kokoro-team kokoro-team removed kokoro:run kokoro:force-run labels Feb 27, 2020
@kolea2 kolea2 added the kokoro:force-run label Feb 27, 2020
@elharo elharo added kokoro:run and removed kokoro:force-run labels Feb 27, 2020
@kokoro-team kokoro-team removed the kokoro:run label Feb 27, 2020
@kolea2 kolea2 merged commit c19bcf8 into master Feb 27, 2020
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants