Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update jacoco to 0.8.5 #883

Merged
merged 1 commit into from Feb 26, 2020
Merged

Conversation

kolea2
Copy link
Contributor

@kolea2 kolea2 commented Feb 26, 2020

No description provided.

@googlebot googlebot added the cla: yes label Feb 26, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 26, 2020

Codecov Report

Merging #883 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #883      +/-   ##
============================================
+ Coverage     78.43%   78.63%   +0.19%     
- Complexity     1156     1163       +7     
============================================
  Files           203      203              
  Lines          5110     5143      +33     
  Branches        402      413      +11     
============================================
+ Hits           4008     4044      +36     
+ Misses          926      925       -1     
+ Partials        176      174       -2
Impacted Files Coverage Δ Complexity Δ
...oogle/api/gax/httpjson/ManagedHttpJsonChannel.java 54% <0%> (-1.11%) 5% <0%> (ø)
...a/com/google/api/gax/grpc/GrpcCallableFactory.java 82.5% <0%> (-1.05%) 11% <0%> (ø)
...m/google/api/gax/httpjson/HttpJsonCallOptions.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
.../google/api/gax/retrying/TimedAttemptSettings.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
...m/google/api/gax/httpjson/ApiMethodDescriptor.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
...api/gax/httpjson/ApiMessageHttpResponseParser.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/com/google/api/gax/rpc/BatcherFactory.java 95.12% <0%> (+0.12%) 9% <0%> (+2%) ⬆️
.../java/com/google/api/gax/grpc/GrpcClientCalls.java 95.65% <0%> (+0.19%) 7% <0%> (ø) ⬇️
.../java/com/google/api/gax/grpc/CallOptionsUtil.java 95.45% <0%> (+0.21%) 6% <0%> (ø) ⬇️
...httpjson/InstantiatingHttpJsonChannelProvider.java 70.96% <0%> (+0.47%) 19% <0%> (ø) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5440bc6...3492e93. Read the comment docs.

@kolea2
Copy link
Contributor Author

@kolea2 kolea2 commented Feb 26, 2020

@suztomo I tried originally taking the approach you had for the java format plugin (onlyIf java 8), but couldn't get it to work - I am not super familiar with gradle so any suggestions appreciated. Instead, I was able to upgrade jacoco for all language levels. Any objections @chingor13 ? This will at least get all builds passing for now.

@kolea2 kolea2 requested a review from chingor13 Feb 26, 2020
@suztomo
Copy link
Member

@suztomo suztomo commented Feb 26, 2020

@kolea2 Nice to see Java 11 build works now and Jacoco plugin upgraded. (My previous attempt failure could be temporary one). 2 birds 1 stone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants