Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused property #887

Merged
merged 1 commit into from Mar 6, 2020
Merged

remove unused property #887

merged 1 commit into from Mar 6, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 27, 2020

@elharo elharo requested a review from kolea2 Feb 27, 2020
@googlebot googlebot added the cla: yes label Feb 27, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 27, 2020

Codecov Report

Merging #887 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #887      +/-   ##
============================================
+ Coverage     78.51%   78.63%   +0.11%     
- Complexity     1157     1163       +6     
============================================
  Files           203      203              
  Lines          5110     5143      +33     
  Branches        402      413      +11     
============================================
+ Hits           4012     4044      +32     
- Misses          923      925       +2     
+ Partials        175      174       -1
Impacted Files Coverage Δ Complexity Δ
...oogle/api/gax/httpjson/ManagedHttpJsonChannel.java 54% <0%> (-1.11%) 5% <0%> (ø)
...a/com/google/api/gax/grpc/GrpcCallableFactory.java 82.5% <0%> (-1.05%) 11% <0%> (ø)
...m/google/api/gax/httpjson/HttpJsonCallOptions.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
.../google/api/gax/retrying/TimedAttemptSettings.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
...m/google/api/gax/httpjson/ApiMethodDescriptor.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
...api/gax/httpjson/ApiMessageHttpResponseParser.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/com/google/api/gax/rpc/BatcherFactory.java 95.12% <0%> (+0.12%) 9% <0%> (+2%) ⬆️
.../java/com/google/api/gax/grpc/GrpcClientCalls.java 95.65% <0%> (+0.19%) 7% <0%> (ø) ⬇️
.../java/com/google/api/gax/grpc/CallOptionsUtil.java 95.45% <0%> (+0.21%) 6% <0%> (ø) ⬇️
...httpjson/InstantiatingHttpJsonChannelProvider.java 70.96% <0%> (+0.47%) 19% <0%> (ø) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37dcc8...bf48a77. Read the comment docs.

lesv
lesv approved these changes Mar 6, 2020
@elharo elharo merged commit 8a203e1 into master Mar 6, 2020
9 checks passed
@elharo elharo deleted the an branch Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants