Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): make it easier to debug failures in SettingsTest #994

merged 2 commits into from Mar 31, 2020


Copy link

@igorbernstein2 igorbernstein2 commented Mar 30, 2020

Currently it's really difficult to debug failures in SettingsTest. If something goes out sync it just tells you the expectation is is unmet. This pr will tell you which attribute path is broken

@googlebot googlebot added the cla: yes label Mar 30, 2020
Copy link

@codecov codecov bot commented Mar 31, 2020

Codecov Report

Merging #994 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #994   +/-   ##
  Coverage     78.66%   78.66%           
  Complexity     1167     1167           
  Files           204      204           
  Lines          5152     5152           
  Branches        413      413           
  Hits           4053     4053           
  Misses          925      925           
  Partials        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a676891...d4a2cb7. Read the comment docs.

Copy link

@vam-google vam-google left a comment

I don't really understand what is going on here, but it is test-only and looks safe, so LGTM =)

Copy link
Collaborator Author

@igorbernstein2 igorbernstein2 commented Mar 31, 2020

Yea, this test is overly complicated. But I didn't want to rewrite it, just needed to get reasonable error messages so that I could finish #993

@igorbernstein2 igorbernstein2 merged commit 909bf1b into googleapis:master Mar 31, 2020
7 of 8 checks passed
@igorbernstein2 igorbernstein2 deleted the better-messaging branch Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants